Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

copy module doesn't follow symbolic directory #13013

Closed
justinligraph opened this issue Nov 3, 2015 · 2 comments · Fixed by #17614 or #23326
Closed

copy module doesn't follow symbolic directory #13013

justinligraph opened this issue Nov 3, 2015 · 2 comments · Fixed by #17614 or #23326
Assignees
@jctanner
Labels
affects_2.2 This issue/PR affects Ansible v2.2 bug This issue/PR relates to a bug. P2 Priority 2 - Issue Blocks Release
Milestone
2.2.0

Comments

@justinligraph
Copy link

justinligraph commented Nov 3, 2015 •
edited by jctanner

ISSUE TYPE

Bug Report

COMPONENT NAME:

copy action plugin

ANSIBLE VERSION

2.0.1.0

SUMMARY

I am copying a folder, foo, which has a subfolder, foo1, which is a symbolic link to another folder say /root/myfoo1. copy module won't copy it to remote location.
@jimi-c
Copy link
Member

jimi-c commented Nov 5, 2015

@justinligraph with which version of Ansible are you seeing this occur?

@jimi-c jimi-c added the needs_info This issue requires further information. Please answer any outstanding questions. label Nov 5, 2015
@keithkostol
Copy link

I can confirm this bug in both 2.0.1.0 (Ubuntu repo) as well as the devel branch from git (pulled today).

I have attached a small self contained demo. It copies a directory that includes a couple symlinks to /tmp/ of the local machine. One symlink is pointed to a file (called "link_to_file"), one is pointed to a directory (called "link_to_dir"). The directory that "link_to_dir" points to never gets copied (dir2), however the file that "link_to_file" points to does (file2).
bugtest.tar.gz

@jimi-c jimi-c added this to the 2.2.0 milestone May 11, 2016
@jimi-c jimi-c removed the needs_info This issue requires further information. Please answer any outstanding questions. label May 11, 2016
@ansibot ansibot added the affects_2.2 This issue/PR affects Ansible v2.2 label Sep 8, 2016
@mckerrj mckerrj added the P2 Priority 2 - Issue Blocks Release label Sep 14, 2016
@jctanner jctanner mentioned this issue Sep 16, 2016
Merged
@jctanner jctanner self-assigned this Sep 16, 2016
bcoca pushed a commit that referenced this issue Sep 16, 2016
@jctanner @bcoca
copy action plugin: recurse into sub folders of the source (#17614)
29fda4b 
* copy action plugin: recurse into sub folders of the source

Fixes #13013

* Fix python3 bytes/strings

* Fix py3 again

* test
sereinity pushed a commit to sereinity-forks/ansible that referenced this issue Jan 25, 2017
@jctanner
copy action plugin: recurse into sub folders of the source (ansible#1…
533fb79 
…7614)

* copy action plugin: recurse into sub folders of the source

Fixes ansible#13013

* Fix python3 bytes/strings

* Fix py3 again

* test
@abadger abadger mentioned this issue Apr 5, 2017
Closed
abadger added a commit to abadger/ansible that referenced this issue Apr 6, 2017
@abadger
Fix for recursive copy slowness
7b7ee00 
Copy module was walking over files in subdirectories repeatedly (a
directory tree a few levels deep could bring the time spent into the
tens of minutes)

This was traced to the fix for this bug report: ansible#13013

Fixed ansible#13013 a different way and added an integration test to check for
regressions of ansible#13013 as we optimize this code.

Fixes ansible#21513
@abadger abadger mentioned this issue Apr 6, 2017
Merged
abadger added a commit that referenced this issue Apr 7, 2017
@abadger
Fix for recursive copy slowness
f55775a 
Copy module was walking over files in subdirectories repeatedly (a
directory tree a few levels deep could bring the time spent into the
tens of minutes)

This was traced to the fix for this bug report: #13013

Fixed #13013 a different way and added an integration test to check for
regressions of #13013 as we optimize this code.

Fixes #21513

(cherry picked from commit 78ced53)
abadger added a commit to abadger/ansible that referenced this issue Apr 7, 2017
@abadger @bcoca
Fix for recursive copy slowness
78ced53 
Copy module was walking over files in subdirectories repeatedly (a
directory tree a few levels deep could bring the time spent into the
tens of minutes)

This was traced to the fix for this bug report: ansible#13013

Fixed ansible#13013 a different way and added an integration test to check for
regressions of ansible#13013 as we optimize this code.

Fixes ansible#21513
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bug_report labels Mar 7, 2018
@ansible ansible locked and limited conversation to collaborators Apr 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jctanner jctanner

Labels
affects_2.2 This issue/PR affects Ansible v2.2 bug This issue/PR relates to a bug. P2 Priority 2 - Issue Blocks Release
Projects
None yet
Milestone
2.2.0
6 participants
@jimi-c @mckerrj @jctanner @ansibot @keithkostol @justinligraph