Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Report: make tests-py3 is broken in devel #13638

Closed
Yannig opened this issue Dec 22, 2015 · 1 comment
Closed

Bug Report: make tests-py3 is broken in devel #13638

Yannig opened this issue Dec 22, 2015 · 1 comment
Labels
bug This issue/PR relates to a bug.
Milestone

Comments

@Yannig
Copy link
Contributor

Yannig commented Dec 22, 2015

Ansible Version:

last devel

Ansible Configuration:

Nothing special

Environment:

Nothing special

Summary:

make tests-py3 is broken

Steps To Reproduce:

Launch make tests-py3

Expected Results:

Tests OK

Actual Results:
======================================================================
FAIL: test_sudo_only_if_user_differs (units.plugins.action.test_action.TestActionBase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/ansible/ansible/test/units/plugins/action/test_action.py", line 52, in test_sudo_only_if_user_differs
    play_context.make_become_cmd.assert_called_once_with('ECHO', executable=None)
  File "/opt/python/3.4.2/lib/python3.4/unittest/mock.py", line 782, in assert_called_once_with
    return self.assert_called_with(*args, **kwargs)
  File "/opt/python/3.4.2/lib/python3.4/unittest/mock.py", line 771, in assert_called_with
    raise AssertionError(_error_message()) from cause
nose.proxy.AssertionError: Expected call: mock('ECHO', executable=None)
Actual call: mock(b'ECHO', executable=None)
    None = (('ECHO',), {'executable': None}) if isinstance((('ECHO',), {'executable': None}), Exception) else None
>>  raise AssertionError(_error_message()) from None
@bcoca bcoca added this to the v2 milestone Dec 22, 2015
@Yannig
Copy link
Contributor Author

Yannig commented Dec 22, 2015

The following commit broke the tests in python3: 0c013f5

Yannig added a commit to Yannig/ansible that referenced this issue Dec 22, 2015
@Yannig Yannig closed this as completed Dec 22, 2015
abadger added a commit that referenced this issue Dec 23, 2015
Revert "Fix make tests-py3 on devel. Fix for #13638."

This reverts commit 725e40c.
abadger added a commit that referenced this issue Jan 5, 2016
This reverts commit e700613.

Going to do this in the connection plugins
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bug_report labels Mar 7, 2018
@ansible ansible locked and limited conversation to collaborators Apr 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue/PR relates to a bug.
Projects
None yet
Development

No branches or pull requests

3 participants