Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The ec2.py dynamic inventory script does not group RDS instances by tag #14464

Closed
karlmdavis opened this issue Feb 13, 2016 · 6 comments
Closed
Labels
affects_2.2 This issue/PR affects Ansible v2.2 affects_2.3 This issue/PR affects Ansible v2.3 bug This issue/PR relates to a bug. needs_info This issue requires further information. Please answer any outstanding questions. needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly. support:core This issue/PR relates to code supported by the Ansible Engineering Team.

Comments

@karlmdavis
Copy link

This makes it unpossible to delete (or otherwise poke at) RDS instances by tag. This would be useful in all the same ways that grouping EC2 instances by tag, e.g. for maintaining separate dev/production instances via an "Environment" tag.

@karlmdavis
Copy link
Author

As an ugly workaround, you can append the environment name to the RDS instance's instance_name property, instead.

For example:

- name: RDS - Provision 'myinstancename'
  rds:
    command: create
    region: "{{ region }}"
    instance_name: myinstancename-{{ env }}
    db_engine: postgres
    size: 10
    instance_type: db.t2.medium
    publicly_accessible: false
    username: "{{ postgres_dev_master_username }}"
    password: "{{ postgres_dev_master_password }}"
    tags:
      # Note: it will create the tag, but that tag won't be used for any grouping when the inventory is built via ec2.py.
      Environment: "{{ env }}"
    wait: true
    wait_timeout: 900

@aioue
Copy link
Contributor

aioue commented Apr 27, 2016

#15609

@ansibot ansibot added triage affects_2.2 This issue/PR affects Ansible v2.2 labels Sep 7, 2016
@ansibot ansibot added the affects_2.3 This issue/PR affects Ansible v2.3 label Dec 13, 2016
@bcoca bcoca removed the triage label Dec 16, 2016
@nethershaw
Copy link

#15609 does not solve this issue. It provides tags for RDS clusters, but not RDS instances.

Why would clusters have received this fix before instances? What obstacles remain to expose the resource tags of RDS instances via dynamic inventory?

@ansibot
Copy link
Contributor

ansibot commented Apr 11, 2017

@karlmdavis Greetings! Thanks for taking the time to open this issue. In order for the community to handle your issue effectively, we need a bit more information.

Here are the items we could not find in your description:

  • issue type
  • ansible version
  • component name

Please set the description of this issue with this template:
https://raw.githubusercontent.com/ansible/ansible/devel/.github/ISSUE_TEMPLATE.md

click here for bot help

@ansibot ansibot added needs_info This issue requires further information. Please answer any outstanding questions. needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly. labels Apr 11, 2017
ElijahLynn added a commit to ElijahLynn/ansible that referenced this issue Apr 25, 2017
Boto3 only at this time.

Relates to ansible#11569, ansible#14464.
pchauncey pushed a commit to pchauncey/ansible that referenced this issue May 9, 2017
* Get tags for RDS instances.

Boto3 only at this time.

Relates to ansible#11569, ansible#14464.

* Add a check for boto3

* Fix HAS_BOTO3 error
dpiotrowski pushed a commit to dpiotrowski/ansible that referenced this issue May 9, 2017
* Get tags for RDS instances.

Boto3 only at this time.

Relates to ansible#11569, ansible#14464.

* Add a check for boto3

* Fix HAS_BOTO3 error
KKoukiou pushed a commit to KKoukiou/ansible that referenced this issue May 22, 2017
* Get tags for RDS instances.

Boto3 only at this time.

Relates to ansible#11569, ansible#14464.

* Add a check for boto3

* Fix HAS_BOTO3 error
@ansibot ansibot added the support:core This issue/PR relates to code supported by the Ansible Engineering Team. label Jun 29, 2017
@ghost
Copy link

ghost commented Sep 1, 2017

Any movement on this issue since May? Seems to not be supported still and would be useful for our use case.

@ansibotdev
Copy link

@karlmdavis You have not responded to information requests in this issue so we will assume it no longer affects you. If you are still interested in this, please create a new issue with the requested information.

click here for bot help

@ansibot ansibot added bug This issue/PR relates to a bug. and removed bug_report labels Mar 7, 2018
@ansible ansible locked and limited conversation to collaborators Apr 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.2 This issue/PR affects Ansible v2.2 affects_2.3 This issue/PR affects Ansible v2.3 bug This issue/PR relates to a bug. needs_info This issue requires further information. Please answer any outstanding questions. needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Development

No branches or pull requests

6 participants