allow subnet names to be used in os_port instead of subnet ids only

[dev00]

ISSUE TYPE

• Feature Idea

COMPONENT NAME

os_port

ANSIBLE VERSION

ansible 2.2.1.0

CONFIGURATION

OS / ENVIRONMENT

N/A

SUMMARY

Right now we can only create instances which will be attached to a specific network. Openstack will then place the instance in the first subnet.
However, when having multiple subnets, you may want to choose in which subnet the instance should be placed.
This can at the moment only be done by creating an openstack port with os_port. os_port will accept only subnet-ids at the moment, which are a little bit messy (because you need to get the id first from the name etc.).
However, the openstack-client already supports creating a port in a subnet and allows the subnet to be chosen by name.

It would be great to take out some restrictions from the os_port module and allow a subnet name or subnet id (this is btw. the default behavior for the network-parameter already) to be supplied instead of allowing an id only.

STEPS TO REPRODUCE

- name: create the port in the needed subnet                                                                                                                                    
  os_port:                                                                                                                                                                      
    state: present                                                                                                                                                              
    fixed_ips:                                                                                                                                                                  
      - subnet: foo                                                                                                                                                          
    network: "first-nw" 
    security_groups: "some_security_group" 
    name: a_port 

EXPECTED RESULTS

That the port would be created.

ACTUAL RESULTS

The step fails and asks for an ID.

fatal: [localhost]: FAILED! => {"changed": false, "failed": true, "msg": "Error creating port for network $network_id: Invalid input for fixed_ips. Reason: 'foo' is not a valid UUID.\nNeutron server returns request_ids: ['$neutron_id']"}

[ansibot]

cc @emonty @Shrews @juliakreger @j2sol @rcarrillocruz @Thingee
click here for bot help

[Thingee]

These just get passed onto the neutron API which supports ip_address and subnet_id. I'm asking on #openstack-neutron irc free node if this can be supported in addition.

[dev00]

Maybe we can take a look at the openstack client how it's handled there? I suppose that an additional step where we get all the subnets and filter by name would be a little bit overkill and shift the responsibility too much torwards the module in Ansible, right?

[Thingee]

@dev00 We pretty much do the name filtering everywhere else in shade. The response I got on #openstack-neutron was to create a new API extension, which makes me very sad.

[ansibot]

cc @dagnello
click here for bot help

[ansibot]

cc @omgjlk
click here for bot help

[ansibot]

cc @mnaser
click here for bot help

[mnaser]

This is currently possible with OpenStack, as the OpenStack API supports getting a subnet ID only and it will grab the first available IP then.

https://developer.openstack.org/api-ref/network/v2/#create-port
fixed_ips (Optional): "If you specify only a subnet ID, OpenStack Networking allocates an available IP from that subnet to the port."

[mnaser]

needs_contributor

[ansibot]

cc @cloudnull @evrardjp @odyssey4me
click here for bot help

[ansibot]

cc @gtema
click here for bot help

[ansibot]

Thank you very much for your interest in Ansible. Ansible has migrated much of the content into separate repositories to allow for more rapid, independent development. We are closing this issue/PR because this content has been moved to one or more collection repositories.

• lib/ansible/modules/cloud/openstack/os_port.py -> https://galaxy.ansible.com/openstack/cloud

For further information, please see:
https://github.com/ansible/ansibullbot/blob/master/docs/collection_migration.md