elasticsearch_plugin: wrong binary and unsupported "timeout" option.

[dobegor]

ISSUE TYPE

• Bug Report

COMPONENT NAME

elasticsearch_plugin

ANSIBLE VERSION

devel

CONFIGURATION

None.

OS / ENVIRONMENT

Ubuntu 16.04 64-bit

SUMMARY

Ansible uses wrong binary by default and passes an unsupported option to plugin installer, so it crashes.

STEPS TO REPRODUCE

Define a plugin install action.

- name: "Install discovery plugin"
  elasticsearch_plugin:
    state: present
    name: discovery-gce

EXPECTED RESULTS

Plugin installed.

ACTUAL RESULTS

fatal: [localhost]: FAILED! => {"changed": false, "cmd": "/usr/share/elasticsearch/bin/plugin install discovery-gce --timeout 1m", "failed": true, "msg": "[Errno 2] No such file or directory", "rc": 2}

OK, default binary is wrong. If I specify the correct binary explicitly, the result is:

fatal: [localhost]: FAILED! => {"changed": false, "failed": true, "msg": "A tool for managing installed elasticsearch plugins\n\nCommands\n--------\nlist - Lists installed elasticsearch plugins\ninstall - Install a plugin\nremove - Removes a plugin from elasticsearch\n\nNon-option arguments:\ncommand              \n\nOption         Description        \n------         -----------        \n-h, --help     show help          \n-s, --silent   show minimal output\n-v, --verbose  show verbose output\nERROR: timeout is not a recognized option\n"}

The problem is that there's no timeout option now in elasticsearch-plugin. Please remove it.
Line

[ansibot]

cc @ThePixelDeveloper
click here for bot help

[ApsOps]

@bcoca I can pick this up, but I'm not sure if we should enable/disable the option by checking the ES version (this might be complicated/overkill), or just remove the default value and add in docs that users should enable this only if their elasticsearch-plugin binary supports it. Users are anyway providing the path to the binary. Thoughts?

[ThePixelDeveloper]

@ApsOps Thanks.

I'm not going to have any time in the next few days so it's much appreciated if someone can get to this before me.

[ghost]

I fixed this in a new pull-request. The default binary was not changed, but can be edited with the plugin_bin parameter.

regards

[ansibot]

cc @samdoran
click here for bot help

[samdoran]

Closing this since it was resolved by #28936, which will be in Ansible 2.4.1.