Unarchive modules always reports 'changed' with non-default permissions on items in zip files. (breaks idempotence)

[chriskarel]

ISSUE TYPE

• Bug Report

COMPONENT NAME

unarchive module

ANSIBLE VERSION

ansible 2.2.1.0
  config file = /etc/ansible/ansible.cfg
  configured module search path = Default w/o overrides

CONFIGURATION

Defaults

OS / ENVIRONMENT

Running on OEL 7.3 (RHEL equivalent)

SUMMARY

Zip files containing items with non-default permissions are always reported as changed, every run. Totally breaking idempotence.

STEPS TO REPRODUCE

### Create two files, and change the permissions on one of them.
$ touch test-777 test-default
$ chmod 777 test-777

### Put both files in seperate zip files
$ zip test-777.zip test-777
  adding: test-777 (stored 0%)
$ zip test-default.zip test-default
  adding: test-default (stored 0%)

#### Make a playbook that unarchives those.
$ cat ../test.yaml
---
- hosts: localhost

  tasks:

  - name: 777 zip
    unarchive:
      src=test-777.zip
      dest=/


  - name: Default zip
    unarchive:
      src=test-default.zip
      dest=/

###  First run should report 'changed' for both tasks.
$ ansible-playbook ../test.yaml 
 [WARNING]: provided hosts list is empty, only localhost is available

PLAY [localhost] ***************************************************************

TASK [setup] *******************************************************************
ok: [localhost]

TASK [777 zip] *****************************************************************
changed: [localhost]

TASK [Default zip] *************************************************************
changed: [localhost]

PLAY RECAP *********************************************************************
localhost                  : ok=3    changed=2    unreachable=0    failed=0   

### Verify the files look proper
$ ls -l /test-777 test-777 /test-default test-default
-rwxrwxrwx. 1 root root 0 Mar  3 11:13 /test-777
-rwxrwxrwx. 1 root root 0 Mar  3 11:13 test-777
-rw-r--r--. 1 root root 0 Mar  3 11:10 /test-default
-rw-r--r--. 1 root root 0 Mar  3 11:10 test-default


### Second run should report no changes.
$ ansible-playbook ../test.yaml --diff
 [WARNING]: provided hosts list is empty, only localhost is available

PLAY [localhost] ***************************************************************

TASK [setup] *******************************************************************
ok: [localhost]

TASK [777 zip] *****************************************************************
.f...p...?? test-777/
changed: [localhost]

TASK [Default zip] *************************************************************
ok: [localhost]

PLAY RECAP *********************************************************************
localhost                  : ok=3    **changed=1**    unreachable=0    failed=0   

EXPECTED RESULTS

The second ansible run should not make/report any changes. The files already exists properly on the destination, due to the first ansible run

ACTUAL RESULTS

The second ansible run reports a change on the file with non-default permissions.

$ ansible-playbook test.yaml --diff
 [WARNING]: provided hosts list is empty, only localhost is available

PLAY [localhost] ***************************************************************

TASK [setup] *******************************************************************
ok: [localhost]

TASK [777 zip] *****************************************************************
.f...p...?? test-777
changed: [localhost]

TASK [Default zip] *************************************************************
ok: [localhost]

PLAY RECAP *********************************************************************
localhost                  : ok=3    **changed=1**    unreachable=0    failed=0   

[ansibot]

cc @dagwieers @pileofrogs
click here for bot help