Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ansible-test integration breaks when there are files other than directories in test/integration/targets/ #26007

Closed
newswangerd opened this issue Jun 22, 2017 · 0 comments · Fixed by #26011
Labels
affects_2.4 This issue/PR affects Ansible v2.4 bug This issue/PR relates to a bug. c:plugins/test

Comments

@newswangerd
Copy link
Member

newswangerd commented Jun 22, 2017

ISSUE TYPE
  • Bug Report
COMPONENT NAME

ansible-test

ANSIBLE VERSION
dnewswan-OSX:ansible dnewswan$ ansible --version
ansible 2.4.0 (devel 921bc0599b) last updated 2017/06/22 08:28:45 (GMT -400)
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/Users/dnewswan/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /Users/dnewswan/code/ansible/lib/ansible
  executable location = /Users/dnewswan/code/ansible/bin/ansible
  python version = 2.7.13 (default, Apr  4 2017, 08:47:57) [GCC 4.2.1 Compatible Apple LLVM 8.1.0 (clang-802.0.38)]
CONFIGURATION
OS / ENVIRONMENT

Mac OS Sierra

SUMMARY

Placing any files in test/integration/targets/, aside from directories, (such as automatically generated .DS_store files on Mac systems) causes ansible-test integration to break

STEPS TO REPRODUCE

Place any file in test/integration/targets/ and run ansible-test integration --docker centos7 yum

EXPECTED RESULTS

Integration tests for yum should run for yum in a centos7 container

ACTUAL RESULTS
dnewswan-OSX:ansible dnewswan$ ansible-test integration -vv --docker centos7 yum
Traceback (most recent call last):
  File "/Users/dnewswan/code/ansible/test/runner/ansible-test", line 628, in <module>
    main()
  File "/Users/dnewswan/code/ansible/test/runner/ansible-test", line 85, in main
    args.func(config)
  File "/Users/dnewswan/code/ansible/test/runner/lib/executor.py", line 239, in command_posix_integration
    internal_targets = command_integration_filter(args, walk_posix_integration_targets())
  File "/Users/dnewswan/code/ansible/test/runner/lib/executor.py", line 459, in command_integration_filter
    targets = tuple(targets)
  File "/Users/dnewswan/code/ansible/test/runner/lib/target.py", line 224, in walk_posix_integration_targets
    for target in walk_integration_targets():
  File "/Users/dnewswan/code/ansible/test/runner/lib/target.py", line 257, in walk_integration_targets
    yield IntegrationTarget(path, modules, prefixes)
  File "/Users/dnewswan/code/ansible/test/runner/lib/target.py", line 425, in __init__
    contents = sorted(os.listdir(path))
OSError: [Errno 20] Not a directory: 'test/integration/targets/.DS_Store'
@ansibot ansibot added affects_2.4 This issue/PR affects Ansible v2.4 bug_report c:plugins/test needs_triage Needs a first human triage before being processed. labels Jun 22, 2017
newswangerd pushed a commit to newswangerd/ansible that referenced this issue Jun 22, 2017
mattclay pushed a commit that referenced this issue Jun 22, 2017
@s-hertel s-hertel removed the needs_triage Needs a first human triage before being processed. label Jun 23, 2017
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bug_report labels Mar 7, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.4 This issue/PR affects Ansible v2.4 bug This issue/PR relates to a bug. c:plugins/test
Projects
None yet
3 participants