Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ansible requires iproute2 package for network facts #26148

Closed
kayrus opened this issue Jun 27, 2017 · 4 comments · Fixed by #70796
Closed

ansible requires iproute2 package for network facts #26148

kayrus opened this issue Jun 27, 2017 · 4 comments · Fixed by #70796
Assignees
@Akasurde
Labels
affects_2.3 This issue/PR affects Ansible v2.3 bug This issue/PR relates to a bug. docs This issue/PR relates to or includes documentation. has_pr This issue has an associated PR. module This issue/PR relates to a module. support:core This issue/PR relates to code supported by the Ansible Engineering Team. system System category

Comments

@kayrus
Copy link

kayrus commented Jun 27, 2017

ISSUE TYPE
  • Bug Report
  • Documentation Report
COMPONENT NAME

setup module

ANSIBLE VERSION

ansible 2.3.1

CONFIGURATION

default

OS / ENVIRONMENT

targeet host without iproute2 package

SUMMARY

https://github.com/ansible/ansible/blob/v2.3.1.0-1/lib/ansible/module_utils/facts.py#L2460

This information should be avaialbe in facts documentation. And there should be a list of packages which should be installed for each type of fact. Or at least use different source of data for these kind of facts.

STEPS TO REPRODUCE

run setup module on host without iproute2 package

EXPECTED RESULTS

network interfaces should be available

ACTUAL RESULTS

there are no facts about network interfaces.
@ansibot ansibot added affects_2.3 This issue/PR affects Ansible v2.3 bug_report module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jun 27, 2017
@robbmanes
Copy link

BSD facts do this without iproute2, wherein they use their version of route and ifconfig to determine the facts for all of the interfaces and determine which holds the default route - you can see this here. Since these have been present on every distro I've ever worked on, maybe those would be enough?

The problem is that there isn't an equivalent of route get for Linux that I am aware of, so to determine the default you'd have to explicitly look it up in the routing table using Linux's version of route, which in 99% of cases is probably fine unless you're using more than one routing table or, for some reason, have more than two default gateways (we'd have to just make sure we pick the first to be applied).

Hopefully that helps on however this gets addressed.

@nitzmahone nitzmahone added docs_report and removed needs_triage Needs a first human triage before being processed. labels Jun 29, 2017
@ansibot
Copy link
Contributor

ansibot commented Aug 24, 2017

cc @david_obrien
click here for bot help

@jaredledvina
Copy link

Adding to this that the default ubuntu:16.04 docker image currently does not ship with iproute2 by default which also causes this variable to disappear as described.

@ansibot ansibot added docs This issue/PR relates to or includes documentation. bug This issue/PR relates to a bug. and removed docs_report labels Mar 1, 2018
@ansibot
Copy link
Contributor

ansibot commented Nov 26, 2018

cc @davidobrien1985
click here for bot help

@ansibot ansibot added the system System category label Feb 17, 2019
@Akasurde Akasurde mentioned this issue Jul 22, 2020
Merged
Akasurde added a commit to Akasurde/ansible that referenced this issue Jul 22, 2020
@Akasurde
docs: Add a note about package requirements for fact gathering
f10a308 
Fixes: ansible#26148

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@Akasurde Akasurde self-assigned this Jul 23, 2020
Akasurde added a commit to Akasurde/ansible that referenced this issue Jul 23, 2020
@Akasurde
docs: Add a note about package requirements for fact gathering
6a7c259 
Fixes: ansible#26148

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@ansibot ansibot added the has_pr This issue has an associated PR. label Jul 23, 2020
acozine pushed a commit that referenced this issue Aug 3, 2020
@Akasurde
docs: Add a note about package requirements for fact gathering (#70796)
a6725d6 
Fixes: #26148

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
samccann pushed a commit to samccann/ansible that referenced this issue Aug 6, 2020
@Akasurde @samccann
docs: Add a note about package requirements for fact gathering (ansib…
32f6dc2 
…le#70796)

Fixes: ansible#26148

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit a6725d6)
acozine added a commit that referenced this issue Aug 7, 2020
@samccann @Akasurde
@s-hertel @relrod @bcoca @Qalthos @acozine @bjosullivan @HurSungYun @felixfontein @bmillemathias @abadger
Docs [2.10] Backportapalooza 6 (#71129)
b9a406f 
* Misc typo fixes (#71089)

(cherry picked from commit 504ef60)

* Add some documentation for the format of meta/runtime.yml (#71035)

* Document the format of meta/runtime.yml

* Document multiple Ansible versions

Clarify difference between deprecation and tombstone fields

* add note

(cherry picked from commit a9eb8b0)

* add note to uninstall older versions of ansible for pip (#71023)

* add note to uninstall older versions of ansible for pip

* combine with the other PR

(cherry picked from commit 72d3d44)

* VMware: Inventory scenario guide for hostnames (#71055)

Added a scenario guide for ``hostnames`` parameter
for vmware_vm_inventory.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit 0055673)

* Document string tests a bit more (#71049)

- Explain how `regex` differs from `match` and `search`.
- Document `multiline` and `ignorecase`.

Signed-off-by: Rick Elrod <rick@elrod.me>
(cherry picked from commit 701c638)

* docs: Add a note about package requirements for fact gathering (#70796)

Fixes: #26148

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit a6725d6)

* added note about fakeroot (#71018)

see #70895

(cherry picked from commit 11a31e9)

* Update documentation of httpapi's handle_httperror method for clarity (#70991)

(cherry picked from commit a0523e5)

* DOCS: add 2.10 collections roadmap (#70975)

* draft of 2.10 collections roadmap

* incorporates feedback from felixfontein

* gundalow and samccann feedback, fix link

Co-authored-by: Alicia Cozine <acozine@users.noreply.github.com>
(cherry picked from commit 9879da8)

* updates changelog types; some updates for easier translation (#71027)

Co-authored-by: Alicia Cozine <acozine@users.noreply.github.com>
Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 4f4436c)

* Document common return values with examples (#71046)

* adding return value examples
* shift to console code blocks
* cleaning up whitespace and shortening invocation example
* reordering diff section

(cherry picked from commit 864573a)

* Update intro_getting_started.rst (#71039)

Added two additional learning resources in the See also: section- forgot closing backticks

(cherry picked from commit 9850915)

* Guide users to use ansible-runner (#71063)

Update the docs to guide users to use `ansible-runner` instead of using Python API directly. In many use cases, executing Ansible playbooks are sufficient. In those use cases, `ansible-runner` is easier and much stable to use comparing with Python API, but there is no mention of it.

(cherry picked from commit 0c855dc)

* Porting guides for ansible-base 2.10 and ansible 2.10 (#70891)

* Fix changelog link title.

* Rename Ansible 2.10 and 2.11 porting guides to Ansible-base porting guides.

* Add stub for automatically generated 2.10 porting guide.

* Move things that should not be in the ansible-base porting guide to the ansible porting guide.

* Apply changes to base porting guides.

* Add remark that ansible-base is mainly for developers.

* Ansible Base -> Ansible-base

* Fix link in base porting guide.

* Add generated porting guide.

* Use same header signs as antsibull-changelog's RST builder.

* Update generated porting guide.

(cherry picked from commit 61b36c6)

* Update network platform guides with FQCN (#70699)

* fqcn all the docs things!

(cherry picked from commit 54bee71)

* Document how to upgrade to ansible with pip (#70768)

Fixes #70348

(cherry picked from commit 5019335)

* document how to migrate between collections (#70243)

* document how to migrate between collections
* Apply suggestions from code review

Co-authored-by: John R Barker <john@johnrbarker.com>
Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 58145df)

* remove github link from plugins (#70951)

(cherry picked from commit e28b20d)

* Add latest rc from ansible-base (#70974)

* Add latest rc from ansible-base

(cherry picked from commit d62dffa)

* Document to_json will convert to ASCII strings by default (#70954)

... as reported in issue #68702

(cherry picked from commit 8c48366)

* Update the porting guide for ansible-2.10.0a8 (#71141)

(cherry picked from commit 0a9638c)

Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
Co-authored-by: Sloane Hertel <shertel@redhat.com>
Co-authored-by: Rick Elrod <rick@elrod.me>
Co-authored-by: Brian Coca <bcoca@users.noreply.github.com>
Co-authored-by: Nathaniel Case <ncase@redhat.com>
Co-authored-by: Alicia Cozine <879121+acozine@users.noreply.github.com>
Co-authored-by: Terciero <terciero@users.noreply.github.com>
Co-authored-by: Brendon O'Sullivan <49501251+bjosullivan@users.noreply.github.com>
Co-authored-by: EthanHur <ethan0311@gmail.com>
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Baptiste Mille-Mathias <baptiste.millemathias@gmail.com>
Co-authored-by: Toshio Kuratomi <a.badger@gmail.com>
zoredache pushed a commit to zoredache/ansible that referenced this issue Aug 10, 2020
@Akasurde @zoredache
docs: Add a note about package requirements for fact gathering (ansib…
47729ba 
…le#70796)

Fixes: ansible#26148

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@ansible ansible locked and limited conversation to collaborators Aug 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Akasurde Akasurde

Labels
affects_2.3 This issue/PR affects Ansible v2.3 bug This issue/PR relates to a bug. docs This issue/PR relates to or includes documentation. has_pr This issue has an associated PR. module This issue/PR relates to a module. support:core This issue/PR relates to code supported by the Ansible Engineering Team. system System category
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: Add a note about package requirements for fact gathering Akasurde/ansible
6 participants
@Akasurde @robbmanes @kayrus @ansibot @nitzmahone @jaredledvina