Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ec2_eni module does not allow to assign additional secondary private ip #26575

Closed
pvshewale opened this issue Jul 10, 2017 · 2 comments · Fixed by #26596
Closed

ec2_eni module does not allow to assign additional secondary private ip #26575

pvshewale opened this issue Jul 10, 2017 · 2 comments · Fixed by #26596
Labels
affects_2.2 This issue/PR affects Ansible v2.2 aws bug This issue/PR relates to a bug. cloud module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community.

Comments

@pvshewale
Copy link

ISSUE TYPE
  • Bug Report
COMPONENT NAME
  • ec2_eni
ANSIBLE VERSION
ansible 2.2.2.0
  config file = /home/pshewale/ansible.cfg
  configured module search path = ['library']
OS / ENVIRONMENT

NA

SUMMARY

When using ec2_eni module to modify existing network interface on AWS, it does not allow to assign additional secondary private IP. It removed all existing secondary private IP addresses, instead of just assigning additional one.

STEPS TO REPRODUCE
  1. Get an ec2 instance where multiple private IPs are allowed ( for example c4.xlarge allows 15 IPs)
  2. Make sure its network interface is already having one or more secondary private IPs
  3. Try to assign new secondary private IP using ec2_eni module
- ec2_eni:
        region: us-east-1
        eni_id: eni-yyyyyyyy
        state: present
        secondary_private_ip_addresses: 172.16.1.3
EXPECTED RESULTS

It should assign additional secondary private IP instead of overwriting it.

ACTUAL RESULTS

It removed existing secondary private IP and then added new one.
@ansibot
Copy link
Contributor

ansibot commented Jul 10, 2017

cc @wimnat
click here for bot help

@ansibot ansibot added affects_2.2 This issue/PR affects Ansible v2.2 aws bug_report cloud module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. labels Jul 10, 2017
@s-hertel s-hertel mentioned this issue Jul 10, 2017
Merged
@s-hertel s-hertel removed the needs_triage Needs a first human triage before being processed. label Jul 10, 2017
@ansibot
Copy link
Contributor

ansibot commented Nov 21, 2017

cc @willthames
click here for bot help

abadger pushed a commit to abadger/ansible that referenced this issue Jan 29, 2018
@s-hertel @ryansb
[cloud] ec2_eni: Add a purge option for secondary ip addresses - fixes …
fed4217 
…ansible#26575 (ansible#26596)

* add purge option for secondary ip addresses and fix changed to reflect when addresses are modified

* Improve option documentation and make the secondary_private_ip_addresses option required if purging secondary private ip addresses.

* ec2_eni: update version_added to 2.5 for purge_secondary_private_ip_addresses option.
Lujeni pushed a commit to Lujeni/ansible that referenced this issue Feb 1, 2018
@s-hertel @Lujeni
[cloud] ec2_eni: Add a purge option for secondary ip addresses - fixes …
0d1d37c 
…ansible#26575 (ansible#26596)

* add purge option for secondary ip addresses and fix changed to reflect when addresses are modified

* Improve option documentation and make the secondary_private_ip_addresses option required if purging secondary private ip addresses.

* ec2_eni: update version_added to 2.5 for purge_secondary_private_ip_addresses option.
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bug_report labels Mar 7, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
affects_2.2 This issue/PR affects Ansible v2.2 aws bug This issue/PR relates to a bug. cloud module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ec2_eni: Add a purge option for secondary ip addresses - fixes #26575 s-hertel/ansible
3 participants
@ansibot @pvshewale @s-hertel