Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace - Clarified regex docs #26727

Merged
merged 2 commits into from
Aug 14, 2017

Conversation

EvanK
Copy link
Contributor

@EvanK EvanK commented Jul 12, 2017

SUMMARY

Clarified the ramifications of python's MULTILINE modifier, as well as negated character sets and the unexpected effects they can have in matching across multiple lines (see #26712).

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

replace module

ANSIBLE VERSION
ansible 2.2.0.0
  config file = /Users/ekaufman/.ansible.cfg
  configured module search path = Default w/o overrides

@ansibot ansibot added affects_2.4 This issue/PR affects Ansible v2.4 community_review In order to be merged, this PR must follow the community review workflow. docs_pull_request module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community. labels Jul 12, 2017
@ansibot
Copy link
Contributor

ansibot commented Jul 12, 2017

The test ansible-test sanity --test ansible-doc --python 2.6 failed with the following error:

Command "ansible-doc replace" returned exit status 1.
>>> Standard Error
[ERROR]: unable to parse
/root/src/github.com/ansible/ansible/lib/ansible/modules/files/replace.py
ERROR! module replace missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test ansible-doc --python 2.7 failed with the following error:

Command "ansible-doc replace" returned exit status 1.
>>> Standard Error
[ERROR]: unable to parse
/root/src/github.com/ansible/ansible/lib/ansible/modules/files/replace.py
ERROR! module replace missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test ansible-doc --python 3.5 failed with the following error:

Command "ansible-doc replace" returned exit status 1.
>>> Standard Error
[ERROR]: unable to parse
/root/src/github.com/ansible/ansible/lib/ansible/modules/files/replace.py
ERROR! module replace missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test ansible-doc --python 3.6 failed with the following error:

Command "ansible-doc replace" returned exit status 1.
>>> Standard Error
[ERROR]: unable to parse
/root/src/github.com/ansible/ansible/lib/ansible/modules/files/replace.py
ERROR! module replace missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test validate-modules failed with the following error:

lib/ansible/modules/files/replace.py:60:1: E302 DOCUMENTATION is not valid YAML

click here for bot help

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. community_review In order to be merged, this PR must follow the community review workflow. needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. and removed community_review In order to be merged, this PR must follow the community review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. labels Jul 12, 2017
@calfonso calfonso removed the needs_triage Needs a first human triage before being processed. label Jul 13, 2017
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jul 21, 2017
@EvanK EvanK force-pushed the 26712-replace-docs-clarification branch from bf83668 to a55137d Compare July 21, 2017 22:19
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jul 21, 2017
@EvanK EvanK force-pushed the 26712-replace-docs-clarification branch from a55137d to e1db260 Compare July 27, 2017 18:00
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Aug 4, 2017
@dharmabumstead dharmabumstead merged commit 767be93 into ansible:devel Aug 14, 2017
@ansibot ansibot added docs This issue/PR relates to or includes documentation. and removed docs_pull_request labels Mar 4, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.4 This issue/PR affects Ansible v2.4 community_review In order to be merged, this PR must follow the community review workflow. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. owner_pr This PR is made by the module's maintainer. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants