Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Its impossible use changeset_name parameter in cloudformation module #27487

Closed
gregory-dan opened this issue Jul 31, 2017 · 4 comments · Fixed by #27518
Closed

Its impossible use changeset_name parameter in cloudformation module #27487

gregory-dan opened this issue Jul 31, 2017 · 4 comments · Fixed by #27518
Labels
affects_2.4 This issue/PR affects Ansible v2.4 aws bug This issue/PR relates to a bug. cloud module This issue/PR relates to a module.

Comments

@gregory-dan
Copy link
Contributor

ISSUE TYPE
  • Bug Report
COMPONENT NAME

cloudformation

ANSIBLE VERSION
ansible 2.4.0 (devel 97aaf103e8) last updated 2017/07/31 15:29:18 (GMT +300)
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/home/admin/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /home/admin/ansible/lib/ansible
  executable location = /home/admin/ansible/bin/ansible
  python version = 2.7.5 (default, Sep 15 2016, 22:37:39) [GCC 4.8.5 20150623 (Red Hat 4.8.5-4)]
CONFIGURATION
OS / ENVIRONMENT

N/A

SUMMARY

Using "changeset_name" parameter results in error:

"msg": "local variable 'changeset_name' referenced before assignment local variable 'changeset_name' referenced before assignment - <type 'exceptions.UnboundLocalError'>"

STEPS TO REPRODUCE
- name: Creating/Updating stack
  cloudformation:
    stack_name:   "{{stack_name}}"
    profile:      "{{profile}}"
    region:       "{{region}}"
    state:        "{{stack_state}}"
    template_url: "test-change-set.yaml"
    changeset_name: test1
    create_changeset: true
  register:     "{{stack_name}}"
EXPECTED RESULTS

change set is created with predefined name

ACTUAL RESULTS

Fails with error above


@gregory-dan
Copy link
Contributor Author

The fix is simple. I tried to push the fix but I get 403 error.
How can I contribute the fix to project ?

@ansibot
Copy link
Contributor

ansibot commented Jul 31, 2017

@ansibot ansibot added affects_2.4 This issue/PR affects Ansible v2.4 aws bug_report cloud module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. labels Jul 31, 2017
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Jul 31, 2017
@tedder
Copy link
Contributor

tedder commented Jul 31, 2017

Hi- thanks for trying to fix! You'll need to clone the Ansible repo, (optionally but recommended) create a branch, and then create a pull request. Once you push the branch to your repo, Github will show you a button to create the PR. Just reference #27487 in that pull request (by using the # sign and the number 27487). I'll then review the code and we can work through any minor issues.

This is a good tutorial on how to fork/branch/PR: https://yangsu.github.io/pull-request-tutorial/

Feel free to ask here for any help.

gregory-dan added a commit to gregory-dan/ansible that referenced this issue Jul 31, 2017
@gregory-dan
Copy link
Contributor Author

Not related to this issue,

Do you have plans to implement execute-change-set as well ?

gregory-dan added a commit to gregory-dan/ansible that referenced this issue Aug 3, 2017
gregory-dan added a commit to gregory-dan/ansible that referenced this issue Aug 3, 2017
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bug_report labels Mar 7, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.4 This issue/PR affects Ansible v2.4 aws bug This issue/PR relates to a bug. cloud module This issue/PR relates to a module.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants