Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undefined variables in boundary_meter #29387

Closed
ansibot opened this issue Sep 11, 2017 · 3 comments
Closed

Undefined variables in boundary_meter #29387

ansibot opened this issue Sep 11, 2017 · 3 comments
Labels
affects_2.2 This issue/PR affects Ansible v2.2 bug This issue/PR relates to a bug. module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community.

Comments

@ansibot
Copy link
Contributor

ansibot commented Sep 11, 2017

From @abadger on 2016-10-23T23:16:22Z

ISSUE TYPE
  • Bug Report
COMPONENT NAME

monitoring/boundary_meter.py

ANSIBLE VERSION
devel 2.2
SUMMARY

When porting to python3 I ran pyflakes on boundary_meter.py and found that there are several undefined variables. These probably make state=absent traceback and state=present when the cert file needs to be downloaded.

delete_meter problem

https://github.com/ansible/ansible-modules-extras/blob/devel/monitoring/boundary_meter.py#L191

action is used here but not defined at this point in the code.

create_meter problems

https://github.com/ansible/ansible-modules-extras/blob/devel/monitoring/boundary_meter.py#L216

At this point result is not defined. Perhaps you meant response instead?

Copied from original issue: ansible/ansible-modules-extras#3277

@ansibot
Copy link
Contributor Author

ansibot commented Sep 11, 2017

From @ansibot on 2016-10-23T23:16:22Z

@ccollicutt ping, this issue is waiting for your response.
click here for bot help

@ansibot
Copy link
Contributor Author

ansibot commented Sep 11, 2017

From @ccollicutt on 2016-10-23T23:16:22Z

Hi, I don't think boundary exists as a service any more, so I'm sorry but this module should just be removed. I actually thought it had been. My apologies.

@ansibot ansibot added affects_2.2 This issue/PR affects Ansible v2.2 bug_report module This issue/PR relates to a module. python3 support:community This issue/PR relates to code supported by the Ansible community. labels Sep 11, 2017
@abadger abadger removed the python3 label Oct 10, 2017
abadger added a commit to abadger/ansible that referenced this issue Oct 10, 2017
@jborean93
Copy link
Contributor

The service no longer exists so this module will no longer work, the module was removed in #31506 and won't be available in future Ansible versions.

jborean93 pushed a commit that referenced this issue Oct 11, 2017
BondAnthony pushed a commit to BondAnthony/ansible that referenced this issue Oct 14, 2017
mtb-xt pushed a commit to mtb-xt/ansible that referenced this issue Oct 15, 2017
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bug_report labels Mar 7, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.2 This issue/PR affects Ansible v2.2 bug This issue/PR relates to a bug. module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Development

No branches or pull requests

3 participants