apt module uses apt-get --autoremove even if autoremove=no

[ashikv]

ISSUE TYPE

• Bug Report

COMPONENT NAME

apt

ANSIBLE VERSION

ansible 2.4.0.0 (detached HEAD 3c805f85bc) last updated 2017/09/18 18:23:57 (GMT +300)
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/home/vashik/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /home/vashik/opt/ansible/lib/ansible
  executable location = /home/vashik/opt/ansible/bin/ansible
  python version = 2.7.12 (default, Nov 19 2016, 06:48:10) [GCC 5.4.0 20160609]

CONFIGURATION

OS / ENVIRONMENT

Debian Jessie

SUMMARY

If aptitude is missing apt module falls back to using apt-get but uses an option --autoremove that some versions of apt-get do not understood

STEPS TO REPRODUCE

Set up a minimal Debian Jessie system, it won't have aptitude installed.
Try to apply updates using apt module on it.

ansible -i target-host-name, target-host-name -m apt -sa 'upgrade=yes update_cache=yes autoclean=no autoremove=no' -vv

EXPECTED RESULTS

Apt module does not use --autoremove when autoremove=no
Apt module has default value no for autoremove
Apt module does not try to use --autoremove when apt-get does not support it

ACTUAL RESULTS

target-host-name | FAILED! => {
    "changed": false,
    "failed": true,
    "msg": "'/usr/bin/apt-get upgrade --with-new-pkgs --autoremove' failed: E: Command line option --autoremove is not understood\n",
    "rc": 100,
    "stdout": "",
    "stdout_lines": []
}

[ansibot]

cc @mgwilliams
click here for bot help

[nrwahl2]

Yeah this looks problematic.

def upgrade(m, mode="yes", force=False, default_release=None,
            use_apt_get=False,
            dpkg_options=expand_dpkg_options(DPKG_OPTIONS)):
    if m.check_mode:
        check_arg = '--simulate'
    else:
        check_arg = ''

    apt_cmd = None
    prompt_regex = None
    if mode == "dist" or (mode == "full" and use_apt_get):
        # apt-get dist-upgrade
        apt_cmd = APT_GET_CMD
        upgrade_command = "dist-upgrade"
    elif mode == "full" and not use_apt_get:
        # aptitude full-upgrade
        apt_cmd = APTITUDE_CMD
        upgrade_command = "full-upgrade"
    else:
        if use_apt_get:
            apt_cmd = APT_GET_CMD
            upgrade_command = "upgrade --with-new-pkgs --autoremove"
        else:
            # aptitude safe-upgrade # mode=yes # default
            apt_cmd = APTITUDE_CMD
            upgrade_command = "safe-upgrade"
            prompt_regex = r"(^Do you want to ignore this warning and proceed anyway\?|^\*\*\*.*\[default=.*\])"