ansible_pkg_mgr is "unknown" on OpenBSD since 2.4 #30623

sparunakian · 2017-09-20T13:02:55Z

Hi,

ISSUE TYPE

Bug Report

COMPONENT NAME

Facts

ANSIBLE VERSION

ansible 2.4.0.0
  config file = /home/stephane/.ansible.cfg
  configured module search path = [u'/home/stephane/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python2.7/site-packages/ansible
  executable location = /usr/bin/ansible
  python version = 2.7.13 (default, Jul 21 2017, 03:24:34) [GCC 7.1.1 20170630]

CONFIGURATION

ANSIBLE_SSH_CONTROL_PATH(/home/stephane/.ansible.cfg) = %(directory)s/%%h-%%r
ANSIBLE_SSH_PIPELINING(/home/stephane/.ansible.cfg) = True
CACHE_PLUGIN(/home/stephane/.ansible.cfg) = jsonfile
CACHE_PLUGIN_CONNECTION(/home/stephane/.ansible.cfg) = ~/.cache/ansible/
CACHE_PLUGIN_TIMEOUT(/home/stephane/.ansible.cfg) = 39600
DEFAULT_GATHERING(/home/stephane/.ansible.cfg) = smart
DEFAULT_HOST_LIST(/home/stephane/.ansible.cfg) = [u'/home/stephane/ansible/inventory']
DEFAULT_LOG_PATH(/home/stephane/.ansible.cfg) = /tmp/ansible.log
DEFAULT_ROLES_PATH(/home/stephane/.ansible.cfg) = [u'/home/stephane/ansible/roles']
DEFAULT_SQUASH_ACTIONS(/home/stephane/.ansible.cfg) = ['apk', 'apt', 'dnf', 'homebrew', 'pacman', 'pkgng', 'yum', 'zypper']
DEFAULT_VAULT_PASSWORD_FILE(/home/stephane/.ansible.cfg) = /home/stephane/ansible/scripts/get_vault_password.sh
RETRY_FILES_ENABLED(/home/stephane/.ansible.cfg) = False

OS / ENVIRONMENT

Ansible running from ArchLinux, managing an OpenBSD machine.

SUMMARY

Since Ansible 2.4, the ansible_pkg_mgr fact is set to unknown, instead of openbsd_pkg (<= Ansible 2.3.2.0). As the package module uses this variable to choose the package manager to invoke, it became unusable on OpenBSD.

STEPS TO REPRODUCE

Execute the following command with an OpenBSD machine as a target:

ansible openbsd_machine -m setup -a "filter=ansible_pkg_mgr"

EXPECTED RESULTS

openbsd_machine | SUCCESS => {
    "ansible_facts": {
        "ansible_pkg_mgr": "openbsd_pkg"
    }, 
    "changed": false
}

ACTUAL RESULTS

openbsd_machine | SUCCESS => {
    "ansible_facts": {
        "ansible_pkg_mgr": "unknown"
    }, 
    "changed": false, 
    "failed": false
}

Let me know if I can be of any help concerning this issue.

Regards

The text was updated successfully, but these errors were encountered:

bcoca · 2017-09-20T13:39:26Z

cc @alikins

alikins · 2017-09-20T16:20:19Z

@sparunakian What does the 'ansible_system' fact end up being set to? The pkg_mgr fact collection code has a special case for ansible_system='OpenBSD' to set pkg_mgr='openbsd_pkg'

If you can provide the full output of 'ansible openbsd_machine -m setup.py' (all of the facts without filters) that may be useful.

When you use the 'package' module, how does it fail? If possible, please provide a copy of the output from running with verbosity set to '-vvv' or higher (either 'ansible' or 'ansible-playbook' against a host showing the problem, whichever is easier)

alikins · 2017-09-20T16:31:48Z

My suspicion is this is related to the order the facts are collected in, and that 'ansible_system' may not be known when the pkg_mgr fact is collected. There is currently no explicit partial ordering for the facts collection so the ordering may be random which could cause the 'ansible_system' to be unknown when pkg_mgr is determined. If thats the case, I need to go ahead and implement some ordering to the collectors to generally fix this.

bcoca · 2017-09-20T19:27:37Z

also dependencies, since now you can avoid collecting 'platform' information

this allows for proper dependencies on facts already collected fixes ansible#30753 fixes ansible#30623

* Fix pkg_mgr fact on OpenBSD Add a OpenBSDPkgMgrFactCollector that hardcodes pkg_mgr to 'openbsd_pkg'. The ansible collector will choose the OpenBSD collector if the system is OpenBSD and the 'Generic' one otherwise. This removes PkgMgrFactCollectors depenency on the 'system' fact being in collected_facts, which also avoids ordering issues (if the pkg mgr fact is collected before the system fact...) Fixes #30623 (cherry picked from commit 12404f4)

* Fix pkg_mgr fact on OpenBSD Add a OpenBSDPkgMgrFactCollector that hardcodes pkg_mgr to 'openbsd_pkg'. The ansible collector will choose the OpenBSD collector if the system is OpenBSD and the 'Generic' one otherwise. This removes PkgMgrFactCollectors depenency on the 'system' fact being in collected_facts, which also avoids ordering issues (if the pkg mgr fact is collected before the system fact...) Fixes #30623

sparunakian · 2017-09-24T12:33:49Z

Thank you for the fix, it works fine now on devel! Are your requests in #30623 (comment) still required? I did not have time to do that before, but I can do it now.

* Fix fact failures cause by ordering of collectors Some fact collectors need info collected by other facts. (for ex, service_mgr needs to know 'ansible_system'). This info is passed to the Collector.collect method via the 'collected_facts' info. But, the order the fact collectors were running in is not a set order, so collectors like service_mgr could run before the PlatformFactCollect ('ansible_system', etc), so the 'ansible_system' fact would not exist yet. Depending on the collector and the deps, this can result in incorrect behavior and wrong or missing facts. To make the ordering of the collectors more consistent and predictable, the code that builds that list is now driven by the order of collectors in default_collectors.py, and the rest of the code tries to preserve it. * Flip the loops when building collector names iterate over the ordered default_collectors list selecting them for the final list in order instead of driving it from the unordered collector_names set. This lets the list returned by select_collector_classes to stay in the same order as default_collectors.collectors For collectors that have implicit deps on other fact collectors, the default collectors can be ordered to include those early. * default_collectors.py now uses a handful of sub lists of collectors that can be ordered in default_collectors.collectors. fixes #30753 fixes #30623

* Fix fact failures cause by ordering of collectors Some fact collectors need info collected by other facts. (for ex, service_mgr needs to know 'ansible_system'). This info is passed to the Collector.collect method via the 'collected_facts' info. But, the order the fact collectors were running in is not a set order, so collectors like service_mgr could run before the PlatformFactCollect ('ansible_system', etc), so the 'ansible_system' fact would not exist yet. Depending on the collector and the deps, this can result in incorrect behavior and wrong or missing facts. To make the ordering of the collectors more consistent and predictable, the code that builds that list is now driven by the order of collectors in default_collectors.py, and the rest of the code tries to preserve it. * Flip the loops when building collector names iterate over the ordered default_collectors list selecting them for the final list in order instead of driving it from the unordered collector_names set. This lets the list returned by select_collector_classes to stay in the same order as default_collectors.collectors For collectors that have implicit deps on other fact collectors, the default collectors can be ordered to include those early. * default_collectors.py now uses a handful of sub lists of collectors that can be ordered in default_collectors.collectors. fixes #30753 fixes #30623 (cherry picked from commit 95abc1d)

* Fix pkg_mgr fact on OpenBSD Add a OpenBSDPkgMgrFactCollector that hardcodes pkg_mgr to 'openbsd_pkg'. The ansible collector will choose the OpenBSD collector if the system is OpenBSD and the 'Generic' one otherwise. This removes PkgMgrFactCollectors depenency on the 'system' fact being in collected_facts, which also avoids ordering issues (if the pkg mgr fact is collected before the system fact...) Fixes ansible#30623

* Fix fact failures cause by ordering of collectors Some fact collectors need info collected by other facts. (for ex, service_mgr needs to know 'ansible_system'). This info is passed to the Collector.collect method via the 'collected_facts' info. But, the order the fact collectors were running in is not a set order, so collectors like service_mgr could run before the PlatformFactCollect ('ansible_system', etc), so the 'ansible_system' fact would not exist yet. Depending on the collector and the deps, this can result in incorrect behavior and wrong or missing facts. To make the ordering of the collectors more consistent and predictable, the code that builds that list is now driven by the order of collectors in default_collectors.py, and the rest of the code tries to preserve it. * Flip the loops when building collector names iterate over the ordered default_collectors list selecting them for the final list in order instead of driving it from the unordered collector_names set. This lets the list returned by select_collector_classes to stay in the same order as default_collectors.collectors For collectors that have implicit deps on other fact collectors, the default collectors can be ordered to include those early. * default_collectors.py now uses a handful of sub lists of collectors that can be ordered in default_collectors.collectors. fixes ansible#30753 fixes ansible#30623

* Fix pkg_mgr fact on OpenBSD Add a OpenBSDPkgMgrFactCollector that hardcodes pkg_mgr to 'openbsd_pkg'. The ansible collector will choose the OpenBSD collector if the system is OpenBSD and the 'Generic' one otherwise. This removes PkgMgrFactCollectors depenency on the 'system' fact being in collected_facts, which also avoids ordering issues (if the pkg mgr fact is collected before the system fact...) Fixes ansible#30623

* Fix fact failures cause by ordering of collectors Some fact collectors need info collected by other facts. (for ex, service_mgr needs to know 'ansible_system'). This info is passed to the Collector.collect method via the 'collected_facts' info. But, the order the fact collectors were running in is not a set order, so collectors like service_mgr could run before the PlatformFactCollect ('ansible_system', etc), so the 'ansible_system' fact would not exist yet. Depending on the collector and the deps, this can result in incorrect behavior and wrong or missing facts. To make the ordering of the collectors more consistent and predictable, the code that builds that list is now driven by the order of collectors in default_collectors.py, and the rest of the code tries to preserve it. * Flip the loops when building collector names iterate over the ordered default_collectors list selecting them for the final list in order instead of driving it from the unordered collector_names set. This lets the list returned by select_collector_classes to stay in the same order as default_collectors.collectors For collectors that have implicit deps on other fact collectors, the default collectors can be ordered to include those early. * default_collectors.py now uses a handful of sub lists of collectors that can be ordered in default_collectors.collectors. fixes ansible#30753 fixes ansible#30623

ansibot added affects_2.4 This issue/PR affects Ansible v2.4 bug_report needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Sep 20, 2017

bcoca removed the needs_triage Needs a first human triage before being processed. label Sep 20, 2017

alikins added the needs_info This issue requires further information. Please answer any outstanding questions. label Sep 20, 2017

alikins self-assigned this Sep 20, 2017

alikins added the c:module_utils/facts label Sep 20, 2017

alikins added this to the 2.4.0 milestone Sep 20, 2017

alikins mentioned this issue Sep 21, 2017

Fix pkg_mgr fact on OpenBSD #30725

Merged

mscherer mentioned this issue Sep 22, 2017

Ansible_distribution for Ubuntu 10.04 misreported as Mandriva #30693

Closed

bcoca added a commit to bcoca/ansible that referenced this issue Sep 22, 2017

order collecters by priority

87ede41

this allows for proper dependencies on facts already collected fixes ansible#30753 fixes ansible#30623

bcoca mentioned this issue Sep 22, 2017

order collecters by priority #30758

Closed

alikins closed this as completed in #30725 Sep 22, 2017

nusenu mentioned this issue Sep 22, 2017

ansible 2.4.0 breaks OpenBSD support nusenu/ansible-relayor#137

Closed

alikins mentioned this issue Sep 27, 2017

Eliminate unneeded depenencies between fact collectors #31007

Closed

pyup-bot mentioned this issue Jan 1, 2018

Scheduled monthly dependency update for January napalm255/ansible-vmware_inventory#11

Closed

ansibot added bug This issue/PR relates to a bug. and removed bug_report labels Mar 7, 2018

dagwieers added the bsd BSD community label Jan 18, 2019

dagwieers added the packaging Packaging category label Mar 3, 2019

ansible locked and limited conversation to collaborators Apr 26, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ansible_pkg_mgr is "unknown" on OpenBSD since 2.4 #30623

ansible_pkg_mgr is "unknown" on OpenBSD since 2.4 #30623

sparunakian commented Sep 20, 2017

bcoca commented Sep 20, 2017

alikins commented Sep 20, 2017

alikins commented Sep 20, 2017

bcoca commented Sep 20, 2017

sparunakian commented Sep 24, 2017

ansible_pkg_mgr is "unknown" on OpenBSD since 2.4 #30623

ansible_pkg_mgr is "unknown" on OpenBSD since 2.4 #30623

Comments

sparunakian commented Sep 20, 2017

ISSUE TYPE

COMPONENT NAME

ANSIBLE VERSION

CONFIGURATION

OS / ENVIRONMENT

SUMMARY

STEPS TO REPRODUCE

EXPECTED RESULTS

ACTUAL RESULTS

bcoca commented Sep 20, 2017

alikins commented Sep 20, 2017

alikins commented Sep 20, 2017

bcoca commented Sep 20, 2017

sparunakian commented Sep 24, 2017