restrict_facts_namespace is not respected

[nkakouros]

ISSUE TYPE

• Bug Report

ANSIBLE VERSION

ansible 2.5.0
  config file = /home/nikos/Ethical_Hacking/EN2720/ansible.cfg
  configured module search path = [u'/home/nikos/Ethical_Hacking/EN2720/ansible/library']
  ansible python module location = /usr/lib/python2.7/site-packages/ansible
  executable location = /usr/bin/ansible
  python version = 2.7.14 (default, Sep 20 2017, 01:25:59) [GCC 7.2.0]

CONFIGURATION

only defaults

OS / ENVIRONMENT

Running Arch Linux, provisioning Ubuntu 16.04.

SUMMARY

ansible_facts is undefined even when restrict_facts_namespace is set to True.

STEPS TO REPRODUCE

1. Create a playbook.yml with the following contents:

 - hosts: localhost
   tasks:
   - debug: var=ansible_facts

2. Create an ansible.cfg with the following contents:

[defaults]
restrict_facts_namespace = True

3. Run ansible-playbook playbook.yml -vvv

EXPECTED RESULTS

ansible_facts should be printed containing all facts gathered on the localhost.

ACTUAL RESULTS

Ansible fails with:

The full traceback is:
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/ansible/executor/task_executor.py", line 123, in run
    res = self._execute()
  File "/usr/lib/python2.7/site-packages/ansible/executor/task_executor.py", line 562, in _execute
    vars_copy.update(result['ansible_facts'])
ValueError: dictionary update sequence element #0 has length 1; 2 is required

fatal: [localhost]: FAILED! => {
    "msg": "Unexpected failure during module execution.",
    "stdout": ""
}

Changing the debug task to debug: msg="{{ansible_facts}}" results in:

fatal: [localhost]: FAILED! => {
    "msg": "The task includes an option with an undefined variable. The error was: 'ansible_facts' is undefined\n\nThe error appears to have been in '/home/nikos/q/playbook.yml': line 3, column 5, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n  tasks:\n  - debug: msg=\"{{ansible_facts}}\"\n    ^ here\nWe could be wrong, but this one looks like it might be an issue with\nmissing quotes.  Always quote template expression brackets when they\nstart a value. For instance:\n\n    with_items:\n      - {{ foo }}\n\nShould be written as:\n\n    with_items:\n      - \"{{ foo }}\"\n"
}

Setting restrict_facts_namespace to False changes nothing.

[ansibot]

@tterranigma Greetings! Thanks for taking the time to open this issue. In order for the community to handle your issue effectively, we need a bit more information.

Here are the items we could not find in your description:

• component name

Please set the description of this issue with this template:
https://raw.githubusercontent.com/ansible/ansible/devel/.github/ISSUE_TEMPLATE.md

click here for bot help

[bcoca]

This is not currently a feature, it was planned but removed from 2.4 and requeued for possible inclusion in 2.5

I updated the example/ansible.cfg to remove the commented out entry to avoid future confusion

closed via d2c7539