Remove toLower on source in win_chocolatey module #31983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having this here breaks any source URLs that require case sensitivity.
ansibot
added
affects_2.5
|
This looks like a sensible change to me, just curious why it was added in the first place. |
ansibot
removed
the
needs_triage
|
@jhawkesworth I checked the PR it came in with and it doesn't really elude to why it was included - #26523 - so if there was a specific reason (though I can't really think of any) it was unfortunately not documented. |
|
We should not be setting |
jborean93
approved these changes
Oct 22, 2017
|
cherrypicked for the 2.4.2beta1 release. |
abadger
pushed a commit
that referenced
this pull request
Oct 26, 2017
Having this here breaks any source URLs that require case sensitivity. (cherry picked from commit ed342e8)
abadger
pushed a commit
that referenced
this pull request
Oct 26, 2017
Having this here breaks any source URLs that require case sensitivity. (cherry picked from commit ed342e8)
ansibot
added
bug
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having this here breaks any source URLs that require case sensitivity.
SUMMARY
Removes the .toLower from the chocolatey source because it breaks source URLs that may be case sensitive.
For example some private nuget repos use a mixed case string as an identifier that is required to match casing exactly.
ISSUE TYPE
COMPONENT NAME
windows/win_chocolatey
ANSIBLE VERSION