-
Notifications
You must be signed in to change notification settings - Fork 23.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove toLower on source in win_chocolatey module #31983
Conversation
Having this here breaks any source URLs that require case sensitivity.
This looks like a sensible change to me, just curious why it was added in the first place. |
@jhawkesworth I checked the PR it came in with and it doesn't really elude to why it was included - #26523 - so if there was a specific reason (though I can't really think of any) it was unfortunately not documented. |
We should not be setting |
cherrypicked for the 2.4.2beta1 release. |
Having this here breaks any source URLs that require case sensitivity. (cherry picked from commit ed342e8)
Having this here breaks any source URLs that require case sensitivity. (cherry picked from commit ed342e8)
Having this here breaks any source URLs that require case sensitivity.
SUMMARY
Removes the .toLower from the chocolatey source because it breaks source URLs that may be case sensitive.
For example some private nuget repos use a mixed case string as an identifier that is required to match casing exactly.
ISSUE TYPE
COMPONENT NAME
windows/win_chocolatey
ANSIBLE VERSION