FreeBSD portinstall module resubmit #3390
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improved handling when matching multiple package names.
Use ports globbing, so we no longer have to say databases/mysql55-client Remove reference to bad variable.
Only do this when we cannot find the package.
A host pattern of the form '!foo' by itself does not work, but 'all:!foo' does. If the first pattern is a negation, this commit automatically prepends 'all'. Signed-off-by: martin f. krafft <madduck@madduck.net>
The env-setup script is not intended to be run directly, so it does not need a shebang line, which might even create the wrong expectations. Signed-off-by: martin f. krafft <madduck@madduck.net>
dirname/basename do not need an external process, shell variable expansion can be made to do the same a bit faster. Signed-off-by: martin f. krafft <madduck@madduck.net>
…eation in case of already existing destination with the type of 'file'
…ch might appear later)
This does two things:
* add --recursive option to git clone command in clone(). This will
initialize all submodules when cloning a remote repository.
* Add submodule_update() and call that from fetch(). submodule_update()
calls two git commands iff the file .gitmodules exists in the
repository:
* 'git submodule sync' - synchronizes the submodules' remote URL
configuration setting to the value in .gitmodules.
* 'git submodule update --init --recursive' - initialize and update
registered submodules to the commit specified in the index of the
containing repository.
If a repository was cloned without --recursive, submodule_update() will
ensure that the submodules are initialized and updated.
Pass in the `instances` output of the ec2 module to terminate a list of instances that were previously provisioned. Useful for automated testing.
tasks, handlers, and vars main files can now be any of main, main.yml, or main.yaml
When update-rc.d is used to enable/disable service, the changed flag was always true (see #2189). This commit fixes that. Signed-off-by: martin f. krafft <madduck@madduck.net>
ansible.constants was calling expanduser (by way of shell_expand_path) on the entire configured value for the library and *_plugins configuration values, but these values have always been interpreted as multiple directories separated by os.pathsep. Thus, if you supplied multiple directories for one of these values, typically only the first (at least on *nix) would have e.g. "~" expanded to HOME. Now PluginLoader does expansion on each individual path in each of these variables.
Syntax like "'foo' if bar else 'baz'" is not supported by all Python versions targetted by Ansible. Hence we break it up. Signed-off-by: martin f. krafft <madduck@madduck.net>
… Removal of unused variable. Removed unecessary wait_for option. was never been used to begin with. Trim down the stack_outputs. Don't need to include stack name and region since they are already required parameters. Rollback supported in status operations. Using dict when possible.
|
I think I should simply drop this fork, and start from scratch. Probably a better idea :-) |
|
Going to drop my fork and start from scratch. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Michael, your comments on using github properly much appreciated. Have attempted to do what you said, but it still does not look good (does it really say 43 files changed??)
The:
git pull --rebase upstream devel
worked well, got:
From https://github.com/ansible/ansible
First, rewinding head to replay your work on top of it...
Applying: Module to install software on FreeBSD using portinstall
Applying: Updated written by section.
Applying: Very dirty hack to improve check if mysql55-client is installed.
Applying: Delete now works.
Applying: Python likes to compare integers with integers.
Applying: Always removing digits doesn't really work well.
Then I did "git rebase devel", but had to do git rebase --skip a few times.
Apologies again for my lack of knowledge. Have not used pull requests with forked branches before.