basic: allow one or more when param list having choices #34537
Merged
+31
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.5
|
Oh, nice. If we want this we should add unit test. |
ansibot
added
the
needs_revision
gundalow
removed
the
needs_triage
|
lol, ok :) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ansibot
removed
the
needs_revision
|
@dagwieers This has unit tests, which I think area bit better suited, so I'm wondering if this is the better fit. Are you happy with the implementation in this PR? |
ansibot
added
the
stale_ci
bcoca
reviewed
Feb 7, 2018
lib/ansible/module_utils/basic.py
Outdated
| if isinstance(param[k], list): | ||
| for item in param[k]: | ||
| if item not in choices: | ||
| choices_str = ", ".join([to_native(c) for c in choices]) |
There was a problem hiding this comment.
not a required change, but it seems a 'difference' comparison between lists would give you any passed params that are not valid choices in 1 shot and a single error message.
|
Well, that's the original implementation here: https://github.com/ansible/ansible/pull/31637/files#diff-90085fdcec6ed8b273ba885eaee60328R1758 |
ansibot
removed
the
stale_ci
|
rebuild_merge |
nitzmahone
reviewed
Feb 8, 2018
lib/ansible/module_utils/basic.py
Outdated
| @@ -157,7 +157,7 @@ | |||
| except ImportError: | |||
| pass | |||
|
|
|||
| from ansible.module_utils.pycompat24 import get_exception, literal_eval | |||
There was a problem hiding this comment.
I think this change might be the cause of all the import sanity test failures
This comment has been minimized.
This comment has been minimized.
ansibot
added
the
needs_revision
* a number of existing modules expect to be able to get it from basic.py
|
rebuild_merge |
|
unrelated CI issues; merging |
dagwieers
added a commit
to dagwieers/ansible
that referenced
this pull request
Feb 9, 2018
This PR includes: - Fixes related to the recent merge of ansible#31637 and ansible#34537 - A generic fix for a reference for assignment issue - Fixes to aci.boolean() in order to catch exception
dagwieers
added a commit
that referenced
this pull request
Feb 9, 2018
nitzmahone
pushed a commit
that referenced
this pull request
Feb 16, 2018
ansibot
added
feature
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Allow one or more when type='list' with choices.
e.g.
ISSUE TYPE
COMPONENT NAME
basic
ANSIBLE VERSION
ADDITIONAL INFORMATION