Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACI: Fixes to recent change to parameter choices #35968

Merged
merged 1 commit into from Feb 9, 2018
Merged

ACI: Fixes to recent change to parameter choices #35968

merged 1 commit into from Feb 9, 2018

Conversation

dagwieers
Copy link
Contributor

@dagwieers dagwieers commented Feb 9, 2018 •
edited

SUMMARY

This PR includes:

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

aci modules

ANSIBLE VERSION

2.5

@dagwieers dagwieers added the aci Cisco ACI community label Feb 9, 2018
@dagwieers dagwieers added this to the 2.5.0 milestone Feb 9, 2018
@dagwieers dagwieers self-assigned this Feb 9, 2018
@ansibot
Copy link
Contributor

ansibot commented Feb 9, 2018

cc @brunocalogero @jmcgill298 @schunduri
click here for bot help

@ansibot ansibot added bugfix_pull_request community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. networking Network category owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community. labels Feb 9, 2018
@ansibot
Copy link
Contributor

ansibot commented Feb 9, 2018

cc @Qalthos @ganeshrn @gundalow @kedarX @privateip @rcarrillocruz @trishnaguha
click here for bot help

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. support:core This issue/PR relates to code supported by the Ansible Engineering Team. and removed community_review In order to be merged, this PR must follow the community review workflow. owner_pr This PR is made by the module's maintainer. labels Feb 9, 2018
@dagwieers
ACI: Fixes to recent change to parameter choices
ca4dba0 
This PR includes:
- Fixes related to the recent merge of ansible#31637 and ansible#34537
- A generic fix for a reference for assignment issue
- Fixes to aci.boolean() in order to catch exception
@ansibot ansibot added the test This PR relates to tests. label Feb 9, 2018
@dagwieers dagwieers merged commit 01ba3a4 into ansible:devel Feb 9, 2018
@dagwieers dagwieers added this to To Do in 2.5.x blocker list via automation Feb 12, 2018
nitzmahone pushed a commit that referenced this pull request Feb 16, 2018
@dagwieers @nitzmahone
ACI: Fixes to recent change to parameter choices (#35968)
76648f3 
This PR includes:
- Fixes related to the recent merge of #31637 and #34537
- A generic fix for a reference for assignment issue
- Fixes to aci.boolean() in order to catch exception
(cherry picked from commit 01ba3a4)
@nitzmahone
Copy link
Member

cherry-picked to stable-2.5 for 2.5.0b2

@nitzmahone nitzmahone moved this from To Do to Done in 2.5.x blocker list Feb 16, 2018
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@dagwieers dagwieers added the cisco Cisco technologies label Feb 23, 2019
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@dagwieers dagwieers

Labels
aci Cisco ACI community bug This issue/PR relates to a bug. cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. networking Network category support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
No open projects
2.5.x blocker list
  
Done
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dagwieers @ansibot @nitzmahone