HAProxy module does not work with python3 interpreter

[newsletter2go]

ISSUE TYPE

• Bug Report

COMPONENT NAME

HAProxy module

ANSIBLE VERSION

ansible 2.4.0.0
  config file = /home/user/development/provisioner-reloaded/ansible.cfg
  configured module search path = [u'/home/user/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python2.7/dist-packages/ansible
  executable location = /usr/bin/ansible
  python version = 2.7.12 (default, Nov 20 2017, 18:23:56) [GCC 5.4.0 20160609]

CONFIGURATION

ANSIBLE_SSH_ARGS(/home/user/development/provisioner-reloaded/ansible.cfg) = -o ForwardAgent=yes
DEFAULT_LOG_PATH(/home/user/development/provisioner-reloaded/ansible.cfg) = /home/user/development/provisioner-reloaded/ansible.log
HOST_KEY_CHECKING(/home/user/development/provisioner-reloaded/ansible.cfg) = False

OS / ENVIRONMENT

Ansible OS: Ubuntu 16.04
Managed OS: Ubuntu 16.04

SUMMARY

When using python3 as ansible interpreter the haproxy fails while setting the backend to a specific state.

STEPS TO REPRODUCE

- name: Set MySQL backend to maintenance state in HAProxy
  haproxy:
    state: disabled
    host: db-mysql
    backend: mysql_cluster
    socket: /var/run/haproxy.sock
    shutdown_sessions: true

It works when no specific ansible interpreter is set, which means that python 2.7 is used. When setting

ansible_python_interpreter: /usr/bin/python3

in the host vars or group vars before, you get the error shown below. The issue seems to be here https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/net_tools/haproxy.py#L254 .

EXPECTED RESULTS

changed: [managed-host] => {"changed": true, "command": ["get weight mysql_cluster/db-mysql; disable server mysql_cluster/db-mysql; shutdown sessions server mysql_cluster/db-mysql"], "failed": false, "output": ["1 (initial 1)"], "state_after": [{"scur": "0", "status": "MAINT", "weight": "1"}], "state_before": [{"scur": "0", "status": "DOWN", "weight": "1"}]}

ACTUAL RESULTS

fatal: [managed-host]: FAILED! => {"changed": false, "failed": true, "module_stderr": "Connection to 192.168.57.101 closed.\r\n", "module_stdout": "\r\nTraceback (most recent call last):\r\n  File \"/tmp/ansible_28dmn_55/ansible_module_haproxy.py\", line 454, in <module>\r\n    main()\r\n  File \"/tmp/ansible_28dmn_55/ansible_module_haproxy.py\", line 450, in main\r\n    ansible_haproxy.act()\r\n  File \"/tmp/ansible_28dmn_55/ansible_module_haproxy.py\", line 399, in act\r\n    state_before = self.get_state_for(self.backend, self.host)\r\n  File \"/tmp/ansible_28dmn_55/ansible_module_haproxy.py\", line 330, in get_state_for\r\n    data = self.execute('show stat', 200, False).lstrip('# ')\r\n  File \"/tmp/ansible_28dmn_55/ansible_module_haproxy.py\", line 254, in execute\r\n    self.client.sendall('%s\\n' % cmd)\r\nTypeError: a bytes-like object is required, not 'str'\r\n", "msg": "MODULE FAILURE", "rc": 0}

[ansibot]

Files identified in the description:

• lib/ansible/modules/net_tools/haproxy.py

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

[ansibot]

cc @ravibhure
click here for bot help

[sivel]

Easier to read traceback:

Traceback (most recent call last):
  File \"/tmp/ansible_28dmn_55/ansible_module_haproxy.py\", line 454, in <module>
    main()
  File \"/tmp/ansible_28dmn_55/ansible_module_haproxy.py\", line 450, in main
    ansible_haproxy.act()
  File \"/tmp/ansible_28dmn_55/ansible_module_haproxy.py\", line 399, in act
    state_before = self.get_state_for(self.backend, self.host)
  File \"/tmp/ansible_28dmn_55/ansible_module_haproxy.py\", line 330, in get_state_for
    data = self.execute('show stat', 200, False).lstrip('# ')
  File \"/tmp/ansible_28dmn_55/ansible_module_haproxy.py\", line 254, in execute
    self.client.sendall('%s\\n' % cmd)
TypeError: a bytes-like object is required, not 'str'

[ravibhure]

@newsletter2go Thanks for reporting the issue. I update the PR (#35176)

@sivel looking to merge it soon.

[abadger]

#35176 has been merged. Closing this as fixed in devel. I've also created a backport request: #37791 for it to be fixed in 2.5.