Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert azure_rm model pinning #35011

Merged
merged 1 commit into from Jan 17, 2018
Merged

revert azure_rm model pinning #35011

merged 1 commit into from Jan 17, 2018

Conversation

nitzmahone
Copy link
Member

SUMMARY
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

azure_rm_common

ANSIBLE VERSION

2.4.3

ADDITIONAL INFORMATION

model pinning approach is not fully-baked, hold off until 2.5.0/2.4.4

@nitzmahone
revert azure_rm model pinning
b86efcb 
* reverts ansible#33897/ansible#34682
* revisit in 2.4.4/2.5.0
@ansibot
Copy link
Contributor

ansibot commented Jan 17, 2018

cc @brusMX @devigned @haroldwongms @julienstroheker @lmazuel @obsoleted @sozercan @trstringer @tstringer @xscript @yuwzho @zikalino
click here for bot help

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 azure backport This PR does not target the devel branch. bugfix_pull_request cloud core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. owner_pr This PR is made by the module's maintainer. support:certified This issue/PR relates to certified code. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jan 17, 2018
@nitzmahone nitzmahone added this to Blocker in 2.4.x Blocker List Jan 17, 2018
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Jan 17, 2018
@abadger abadger merged commit 949e2f0 into ansible:stable-2.4 Jan 17, 2018
@abadger
Copy link
Contributor

abadger commented Jan 17, 2018

Merged to stable-2.4 for the 2.4.3rc2 release

@nitzmahone nitzmahone moved this from Blocker to Done in 2.4.3 in 2.4.x Blocker List Jan 17, 2018
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 azure backport This PR does not target the devel branch. bug This issue/PR relates to a bug. cloud core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. owner_pr This PR is made by the module's maintainer. support:certified This issue/PR relates to certified code. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
No open projects
2.4.x Blocker List
Done in 2.4.3
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nitzmahone @ansibot @abadger @sivel