Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix azure_rm_storageaccount failure due to new version of Azure Pytho… #33897

Closed
wants to merge 15 commits into from

Conversation

ZhijunZhao
Copy link
Contributor

…n SDK

SUMMARY

The failure is as blow

\"/tmp/ansible_frHOyW/ansible_module_azure_rm_storageaccount.py\", line 416, in create_account\n    poller = self.storage_client.storage_accounts.create(self.resource_group, self.name, parameters)\n  File \"/home/travis/virtualenv/python2.7.14/lib/python2.7/site-packages/azure/mgmt/storage/v2017_06_01/operations/storage_accounts_operations.py\", line 159, in create\n    body_content = self._serialize.body(parameters, 'StorageAccountCreateParameters')\n  File \"/home/travis/virtualenv/python2.7.14/lib/python2.7/site-packages/msrest/serialization.py\", line 460, in body\n    SerializationError, \"Unable to build a model: \"+str(err), err)\n  File \"/home/travis/virtualenv/python2.7.14/lib/python2.7/site-packages/msrest/exceptions.py\", line 48, in raise_with_traceback\n    raise error\nmsrest.exceptions.SerializationError: Unable to build a model: <SkuName.standard_lrs: 'Standard_LRS'> is not valid value for enum <enum 'SkuName'>, DeserializationError: <SkuName.standard_lrs: 'Standard_LRS'> is not valid value for enum <enum 'SkuName'>\n"
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

azure_rm_storageaccount

ANSIBLE VERSION
ansible 2.5.0
  config file = None
  configured module search path = [u'/Users/zhijzhao/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/local/lib/python2.7/site-packages/ansible
  executable location = /usr/local/bin/ansible
  python version = 2.7.14 (default, Sep 25 2017, 09:53:22) [GCC 4.2.1 Compatible Apple LLVM 9.0.0 (clang-900.0.37)]

ADDITIONAL INFORMATION

@zikalino @yuwzho @yaweiw

@ansibot
Copy link
Contributor

ansibot commented Dec 14, 2017

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 azure bugfix_pull_request cloud needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Dec 14, 2017
@ansibot
Copy link
Contributor

ansibot commented Dec 14, 2017

The test ansible-test sanity --test azure-requirements [?] failed with the following error:

Command "test/sanity/code-smell/azure-requirements.py" returned exit status 1.
>>> Standard Output
Update the Azure integration test requirements with the packaging test requirements:
cp packaging/requirements/requirements-azure.txt test/runner/requirements/integration.cloud.azure.txt

click here for bot help

@ansibot ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Dec 14, 2017
@ansibot ansibot added the test This PR relates to tests. label Dec 14, 2017
@yuwzho
Copy link
Contributor

yuwzho commented Dec 14, 2017

shipit

@ansibot ansibot removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. labels Dec 14, 2017
@ZhijunZhao
Copy link
Contributor Author

@nitzmahone

@ansibot
Copy link
Contributor

ansibot commented Dec 25, 2017

@ZhijunZhao this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibot ansibot added merge_commit This PR contains at least one merge commit. Please resolve! module This issue/PR relates to a module. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html support:certified This issue/PR relates to certified code. labels Dec 25, 2017
@ZhijunZhao
Copy link
Contributor Author

@lmazuel Please help to review the code. If you think this is the appropriate solution, I'll make similar changes to the models of other clients.

@ansibot
Copy link
Contributor

ansibot commented Dec 25, 2017

The test ansible-test sanity --test pep8 [?] failed with the following errors:

lib/ansible/modules/cloud/azure/azure_rm_storageaccount.py:354:43: E128 continuation line under-indented for visual indent
lib/ansible/modules/cloud/azure/azure_rm_storageaccount.py:413:82: E127 continuation line over-indented for visual indent

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Dec 25, 2017
@ansibot ansibot added the support:community This issue/PR relates to code supported by the Ansible community. label Dec 28, 2017
@ansibot
Copy link
Contributor

ansibot commented Dec 28, 2017

The test ansible-test sanity --test pep8 [?] failed with the following errors:

lib/ansible/module_utils/azure_rm_common.py:688:34: E128 continuation line under-indented for visual indent
lib/ansible/module_utils/azure_rm_common.py:695:34: E128 continuation line under-indented for visual indent
lib/ansible/module_utils/azure_rm_common.py:697:34: E128 continuation line under-indented for visual indent
lib/ansible/module_utils/azure_rm_common.py:708:34: E128 continuation line under-indented for visual indent
lib/ansible/modules/cloud/azure/azure_rm_image.py:239:28: E128 continuation line under-indented for visual indent
lib/ansible/modules/cloud/azure/azure_rm_image.py:240:28: E128 continuation line under-indented for visual indent
lib/ansible/modules/cloud/azure/azure_rm_image.py:241:28: E128 continuation line under-indented for visual indent
lib/ansible/modules/cloud/azure/azure_rm_image.py:242:28: E128 continuation line under-indented for visual indent
lib/ansible/modules/cloud/azure/azure_rm_image.py:250:34: E128 continuation line under-indented for visual indent
lib/ansible/modules/cloud/azure/azure_rm_image.py:251:34: E128 continuation line under-indented for visual indent
lib/ansible/modules/cloud/azure/azure_rm_image.py:252:34: E128 continuation line under-indented for visual indent
lib/ansible/modules/cloud/azure/azure_rm_networkinterface.py:458:71: E128 continuation line under-indented for visual indent
lib/ansible/modules/cloud/azure/azure_rm_networkinterface.py:459:71: E128 continuation line under-indented for visual indent
lib/ansible/modules/cloud/azure/azure_rm_networkinterface.py:501:75: E128 continuation line under-indented for visual indent
lib/ansible/modules/cloud/azure/azure_rm_networkinterface.py:502:75: E128 continuation line under-indented for visual indent
lib/ansible/modules/cloud/azure/azure_rm_subnet.py:241:78: E128 continuation line under-indented for visual indent
lib/ansible/modules/cloud/azure/azure_rm_subnet.py:242:78: E128 continuation line under-indented for visual indent
lib/ansible/modules/cloud/azure/azure_rm_subnet.py:253:78: E128 continuation line under-indented for visual indent
lib/ansible/modules/cloud/azure/azure_rm_subnet.py:254:78: E128 continuation line under-indented for visual indent
lib/ansible/modules/cloud/azure/azure_rm_virtualmachine.py:941:37: E128 continuation line under-indented for visual indent
lib/ansible/modules/cloud/azure/azure_rm_virtualmachine.py:1648:66: E128 continuation line under-indented for visual indent
lib/ansible/modules/cloud/azure/azure_rm_virtualmachine.py:1649:66: E128 continuation line under-indented for visual indent
lib/ansible/modules/cloud/azure/azure_rm_virtualmachine.py:1651:77: E128 continuation line under-indented for visual indent
lib/ansible/modules/cloud/azure/azure_rm_virtualmachine.py:1652:77: E128 continuation line under-indented for visual indent

The test ansible-test sanity --test pylint [?] failed with the following error:

lib/ansible/modules/cloud/azure/azure_rm_loadbalancer.py:429:46: undefined-variable Undefined variable 'Subnet'

click here for bot help

@ansibot ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Dec 28, 2017
@ansibot
Copy link
Contributor

ansibot commented Dec 28, 2017

The test ansible-test sanity --test pylint [?] failed with the following error:

lib/ansible/modules/cloud/azure/azure_rm_loadbalancer.py:429:46: undefined-variable Undefined variable 'Subnet'

click here for bot help

@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Dec 28, 2017
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jan 5, 2018
@ansibot
Copy link
Contributor

ansibot commented Jan 10, 2018

@ZhijunZhao this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jan 10, 2018
nitzmahone added a commit to nitzmahone/ansible that referenced this pull request Jan 10, 2018
* resolved a number of conflicts
nitzmahone added a commit that referenced this pull request Jan 10, 2018
* resolved a number of conflicts
@nitzmahone
Copy link
Member

nitzmahone commented Jan 10, 2018

merge conflict corrected out-of-band, direct committed to devel, cherry picked to stable-2.4 via #34682 for 2.4.3rc1

@nitzmahone nitzmahone closed this Jan 10, 2018
nitzmahone added a commit to nitzmahone/ansible that referenced this pull request Jan 17, 2018
* reverts ansible#33897/ansible#34682
* revisit in 2.4.4/2.5.0
abadger pushed a commit that referenced this pull request Jan 17, 2018
* reverts #33897/#34682
* revisit in 2.4.4/2.5.0
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.5 This issue/PR affects Ansible v2.5 azure bug This issue/PR relates to a bug. cloud merge_commit This PR contains at least one merge commit. Please resolve! module This issue/PR relates to a module. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. support:certified This issue/PR relates to certified code. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants