nxos_interface_ospf issues

[saichint]

ISSUE TYPE

• Bug Report

COMPONENT NAME

nxos_interface_ospf

ANSIBLE VERSION

ansible 2.5.0 (devel 788010d0f0) last updated 2018/01/08 11:49:21 (GMT -400)
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /root/agents-ci/ansible/lib/ansible
  executable location = /root/agents-ci/ansible/bin/ansible
  python version = 2.7.6 (default, Oct 26 2016, 20:30:19) [GCC 4.8.4]

OS / ENVIRONMENT

Ansible Server : Ubuntu 14.04
Device: N9K running 7.0(3)I5(2)

SUMMARY

There are few issues with nxos_interface_ospf module.

1. The area parameter can be an ipv4 address or the integer equivalent of the ipv4 address. So the range of values is 0-4294967295. However, the code is assuming 0 to 256 only which is wrong.
2. The code also assumes that the current area configuration on the device is already in ipv4 address format, which is not correct. It can be in integer format if the user has provided it in that way before. Some newer platforms do convert the int to ipv4 address and display that but most of the platforms do not, so this cannot be assumed this way.
3. The default value of hello_interval is 10 and this is not handled in the current code.
4. The integration tests do not cover all the parameters (like message-digest etc.).

Note: I will open a PR shortly to address these above issues

[ansibot]

Files identified in the description:

• lib/ansible/modules/network/nxos/nxos_interface_ospf.py

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

[ansibot]

cc @GGabriele @kedarX @mikewiebe @privateip @rahushen @rcarrillocruz @trishnaguha
click here for bot help