Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix nxos_interface_ospf issues #35988

Merged
merged 2 commits into from Feb 13, 2018
Merged

fix nxos_interface_ospf issues #35988

merged 2 commits into from Feb 13, 2018

Conversation

saichint
Copy link
Contributor

@saichint saichint commented Feb 9, 2018 •
edited

SUMMARY

Fixes #35987

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

nxos_interface_ospf

ANSIBLE VERSION
ansible 2.5.0 (devel 788010d0f0) last updated 2018/01/08 11:49:21 (GMT -400)
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /root/agents-ci/ansible/lib/ansible
  executable location = /root/agents-ci/ansible/bin/ansible
  python version = 2.7.6 (default, Oct 26 2016, 20:30:19) [GCC 4.8.4]
ADDITIONAL INFORMATION
  • This PR fixes issues in nxos_interface_ospf issues #35987
  • Documentation correction
  • Integration test cases are enhanced for nxos_interface_ospf module to include all parameters and combinations.
  • Tested on all possible platforms and versions.

@ansibot
Copy link
Contributor

ansibot commented Feb 9, 2018

cc @GGabriele @kedarX @mikewiebe @privateip @rahushen @rcarrillocruz @trishnaguha
click here for bot help

@ansibot ansibot added bugfix_pull_request core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category nxos Cisco NXOS community support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests. labels Feb 9, 2018
@trishnaguha trishnaguha self-assigned this Feb 10, 2018
@trishnaguha trishnaguha removed the needs_triage Needs a first human triage before being processed. label Feb 10, 2018
@trishnaguha trishnaguha added this to the 2.5.0 milestone Feb 10, 2018
trishnaguha
trishnaguha reviewed Feb 12, 2018
View reviewed changes
lib/ansible/modules/network/nxos/nxos_interface_ospf.py Outdated
@@ -95,14 +95,14 @@
message_digest_algorithm_type:
description:
- Algorithm used for authentication among neighboring routers
within an area. Valid values is 'md5'.
within an area. Valid values are 'md5' and 'default'.
required: false
choices: ['md5']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add default in choices also.

trishnaguha
trishnaguha reviewed Feb 12, 2018
View reviewed changes
lib/ansible/modules/network/nxos/nxos_interface_ospf.py Outdated
required: false
choices: ['md5']
default: null
message_digest_encryption_type:
description:
- Specifies the scheme used for encrypting message_digest_password.
Valid values are '3des' or 'cisco_type_7' encryption.
Valid values are '3des' or 'cisco_type_7' encryption or 'default'.
required: false
choices: ['cisco_type_7','3des']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add default in choices also.

@trishnaguha trishnaguha merged commit eab1b62 into ansible:devel Feb 13, 2018
trishnaguha pushed a commit to trishnaguha/ansible that referenced this pull request Feb 13, 2018
@trishnaguha
fix nxos_interface_ospf issues (ansible#35988)
7d8fa2d 
* fix nxos_interface_ospf issues

* review comment

(cherry picked from commit eab1b62)
trishnaguha added a commit that referenced this pull request Feb 13, 2018
@trishnaguha
fix nxos_interface_ospf issues (#35988) (#36090)
be92a5f 
* fix nxos_interface_ospf issues

* review comment

(cherry picked from commit eab1b62)
@trishnaguha
Copy link
Member

cherry-picked to stable-2.5 be92a5f

@saichint saichint deleted the ospf branch February 13, 2018 16:11
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@dagwieers dagwieers added the cisco Cisco technologies label Feb 23, 2019
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@trishnaguha trishnaguha trishnaguha approved these changes

Assignees

@trishnaguha trishnaguha

Labels
bug This issue/PR relates to a bug. cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. networking Network category nxos Cisco NXOS community support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests.
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.

nxos_interface_ospf issues
4 participants
@saichint @ansibot @trishnaguha @dagwieers