include_vars hungs if included file is bad formatted

[nkakouros]

ISSUE TYPE

• Bug Report

COMPONENT NAME

include_vars

ANSIBLE VERSION

ansible 2.6.0 (devel 8743b20c8e) last updated 2018/02/13 17:38:47 (GMT +200)                                                                                                                 
  config file = None                                                                                                                                                                         
  configured module search path = ['/home/nikos/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']                                                                             
  ansible python module location = /home/nikos/Projects/ansible/lib/ansible                                                                                                                  
  executable location = /home/nikos/Projects/ansible/bin/ansible                                                                                                                             
  python version = 3.6.4 (default, Jan  5 2018, 02:35:40) [GCC 7.2.1 20171224]

CONFIGURATION

default

OS / ENVIRONMENT

Arch linux latest

SUMMARY

If the included file has a bad format, then include_vars may hung.

STEPS TO REPRODUCE

playbook.yml:

- hosts: localhost                                                                                                                                                                                  
  tasks:
    - include_vars: vars.yml

vars.yml

q:                                                                                                                                                                                           
  - one                                                                                                                                                                                      
- two

EXPECTED RESULTS

Ansible should exit with error.

ACTUAL RESULTS

Ansible gets stuck while executing the TASK [include_vars] task.

 [WARNING]: No inventory was parsed, only implicit localhost is available

 [WARNING]: provided hosts list is empty, only localhost is available. Note that the implicit localhost does not match 'all'


PLAY [localhost] ****************************************************************************************************************************************************************************

TASK [Gathering Facts] **********************************************************************************************************************************************************************
ok: [localhost]

TASK [include_vars] *************************************************************************************************************************************************************************
^C [ERROR]: User interrupted execution

[ansibot]

Files identified in the description:

• lib/ansible/modules/utilities/logic/include_vars.py

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

[ansibot]

cc @linuxdynasty
click here for bot help

[Akasurde]

@tterranigma I am not able to reproduce this using 2.6, I get following error message -

TASK [include_vars] ************************************************************************************************************
task path: /Volumes/data/src/ansible/playbooks/vmware_related/using_vars.yml:5
fatal: [localhost]: FAILED! => {
    "ansible_facts": {},
    "ansible_included_var_files": [],
    "changed": false,
    "message": "Syntax Error while loading YAML.\n  did not find expected key\n\nThe error appears to have been in '/Volumes/data/src/ansible/playbooks/vmware_related/vars/main.yml': line 3, column 1, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n  - a\n- b\n^ here\n"
}

Can you retry with latest 2.6 ?

[nkakouros]

@Akasurde Yes, it seems to be resolved.

[sivel]

fwiw, I think this was resolved in #38194