Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't pass keyword args as positional, include file_name #38194

Merged
merged 1 commit into from Apr 3, 2018
Merged

Don't pass keyword args as positional, include file_name #38194

merged 1 commit into from Apr 3, 2018

Conversation

sivel
Copy link
Member

@sivel sivel commented Apr 2, 2018

SUMMARY

Don't pass keyword args as positional, include file_name. Fixes #38190

Since this code path has existed, we have always been passing show_content as the file_name parameter. When there was a YAML error, this caused us to try and open True as a file, which results in a hang.

This open is in AnsibleError._get_error_lines_from_file

At minimum this seems to only affect Mac, and does not affect Linux OSes.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/plugins/action/include_vars.py

ANSIBLE VERSION
2.4
2.5
2.6
ADDITIONAL INFORMATION

@sivel sivel mentioned this pull request Apr 2, 2018
Closed
@ansibot ansibot added bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Apr 2, 2018
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Apr 3, 2018
@sivel sivel merged commit ddf937d into ansible:devel Apr 3, 2018
sivel added a commit to sivel/ansible that referenced this pull request Apr 3, 2018
@sivel
Don't pass keyword args as positional, include file_name. Fixes ansib…
caf7422 
…le#38190 (ansible#38194)

(cherry picked from commit ddf937d)
sivel added a commit to sivel/ansible that referenced this pull request Apr 3, 2018
@sivel
Add changelog for ansible#38194
15caf9f
sivel added a commit to sivel/ansible that referenced this pull request Apr 3, 2018
@sivel
Don't pass keyword args as positional, include file_name. Fixes ansib…
850be45 
…le#38190 (ansible#38194)

(cherry picked from commit ddf937d)
sivel added a commit to sivel/ansible that referenced this pull request Apr 3, 2018
@sivel
Add changelog for ansible#38194
0850443
This was referenced Apr 3, 2018
Closed
Merged
ryancurrah pushed a commit to ryancurrah/ansible that referenced this pull request Apr 4, 2018
@sivel @ryancurrah
Don't pass keyword args as positional, include file_name. Fixes ansib…
f83c97d 
…le#38190 (ansible#38194)
samdoran pushed a commit that referenced this pull request Apr 5, 2018
@sivel @samdoran
Backport #38194 for 2.5 - include_vars error fix (#38225)
8277989 
* Don't pass keyword args as positional, include file_name. Fixes #38190 (#38194)

(cherry picked from commit ddf937d)

* Add changelog for #38194
@sivel sivel mentioned this pull request Jul 30, 2018
Closed
ilicmilan pushed a commit to ilicmilan/ansible that referenced this pull request Nov 7, 2018
@sivel @ilicmilan
Don't pass keyword args as positional, include file_name. Fixes ansib…
95c707d 
…le#38190 (ansible#38194)
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
bug This issue/PR relates to a bug. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid yml causes include_vars to hang or freeze without output
2 participants
@sivel @ansibot