nxos_interface issues

[saichint]

ISSUE TYPE

• Bug Report

COMPONENT NAME

nxos_interface

ANSIBLE VERSION

ansible 2.6.0 (devel fed20b825f) last updated 2018/02/15 12:51:12 (GMT -400)
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /root/agents-ci/ansible/lib/ansible
  executable location = /root/agents-ci/ansible/bin/ansible
  python version = 2.7.6 (default, Oct 26 2016, 20:30:19) [GCC 4.8.4]

OS / ENVIRONMENT

Ansible Server : Ubuntu 14.04
Device: N9K running 7.0(3)I5(2)

SUMMARY

There are few issues with nxos_interface. These are affecting 2.5 stable branch as well.

1. interface_type -- this is used to unconfigure 'loopback', 'portchannel' etc. types. So the playbook only needs the type of interface. However, it is failing because playbook has no name or aggregate.
   The offending line seems to be:
   

   ansible/lib/ansible/modules/network/nxos/nxos_interface.py

   Line 758 in f8a89f1

   required_one_of = [['name', 'aggregate']]

Since we do not need, name or aggregate for interface_type, this line should be modified to include interface_type as well

2. Setting mtu is failing. The reason is mtu is an l3 parameter and 'no switchport' command needs to be run first. Currently the code is adding 'no switchport' command after the 'mtu' command and this is causing the issue. The mode (switchport or no switchport) commands must be in the beginning before any other commands need to be run to resolve this.

3. speed is not idempotent. After setting the speed, the code is checking 'show interface ' command to get the existing parameters. This is not a very reliable command for configurations (it is used mainly for run time information). It is better to use 'show run int ' command to resolve this.

4. tx_rate, rx_rate, and neighbors are mainly for checking intent purposes, it looks like. But the documentation only gives this info for neighbors and for tx_rate and rx_rate, it is not clear if they are for checking intent or actually setting parameters. Please clarify.

5. Some parameters current state like speed, mtu, duplex etc. are checked on ethernet interfaces only. If they are only for certain type of interfaces, please enhance the doc to reflect this.

6. fabric_forwarding_anycast_gateway is not idempotent. The problem is coming from:
   

   ansible/lib/ansible/modules/network/nxos/nxos_interface.py

   Line 473 in f8a89f1

   if (fabric_forwarding_anycast_gateway is True and

   
   and
   

   ansible/lib/ansible/modules/network/nxos/nxos_interface.py

   Line 477 in f8a89f1

   elif (fabric_forwarding_anycast_gateway is False and

Basically the conditions check seems wrong, it should be that, if have is true and want is false and vice versa. Currently it is checking both as true vs true and false vs false which is incorrect.

[ansibot]

Files identified in the description:

• lib/ansible/modules/network/nxos/nxos_interface.py

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

[ansibot]

cc @jedelman8 @kedarX @mikewiebe @privateip @rahushen @rcarrillocruz @trishnaguha
click here for bot help

[trishnaguha]

@saichint Thanks for the bug report. Please try this PR #36827 and let us know.