Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nxos_interface multiple issues #36827

Merged
merged 5 commits into from Mar 1, 2018
Merged

Fix nxos_interface multiple issues #36827

merged 5 commits into from Mar 1, 2018

Conversation

trishnaguha
Copy link
Member

@trishnaguha trishnaguha commented Feb 28, 2018 •
edited

Signed-off-by: Trishna Guha trishnaguha17@gmail.com

SUMMARY

fixes #36751

  • interface_type
  • mtu order
  • speed idempotence
  • doc update
  • unittests
  • fabric_forwarding_anycast_gateway idempotence
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

modules/network/nxos/nxos_interface

ANSIBLE VERSION
devel, 2.5

@ansibot
Copy link
Contributor

ansibot commented Feb 28, 2018

cc @Qalthos @ganeshrn @gdpak @gundalow @jedelman8 @kedarX @mikewiebe @privateip @rahushen @rcarrillocruz
click here for bot help

@ansibot ansibot added WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. bugfix_pull_request module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category nxos Cisco NXOS community support:core This issue/PR relates to code supported by the Ansible Engineering Team. support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests. labels Feb 28, 2018
@trishnaguha trishnaguha removed the needs_triage Needs a first human triage before being processed. label Feb 28, 2018
@trishnaguha trishnaguha added this to the 2.5.0 milestone Feb 28, 2018
@trishnaguha trishnaguha changed the title [WIP] nxos_interface fix Fix nxos_interface multiple issues Feb 28, 2018
@trishnaguha trishnaguha added affects_2.5 This issue/PR affects Ansible v2.5 and removed WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. labels Feb 28, 2018
@trishnaguha trishnaguha mentioned this pull request Feb 28, 2018
Closed
@ansibot ansibot added the core_review In order to be merged, this PR must follow the core review workflow. label Feb 28, 2018
@trishnaguha
fix interface_type
616ac78 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
@trishnaguha
fix setting mtu, doc for state check param, doc for params applicable…
0fcf664 
… for ethernet intf

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
@trishnaguha
speed idempotence and add unittest
330a011 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
@trishnaguha
fabric_forwarding_anycast_gateway applicable for svi type intf only
34a6979 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
@trishnaguha
fix speed
59bd672 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
@trishnaguha trishnaguha merged commit 2fbfce0 into ansible:devel Mar 1, 2018
@trishnaguha trishnaguha deleted the nxos_interface branch March 1, 2018 05:26
trishnaguha added a commit to trishnaguha/ansible that referenced this pull request Mar 1, 2018
@trishnaguha
Fix nxos_interface multiple issues (ansible#36827)
94cde82 
* fix interface_type

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* fix setting mtu, doc for state check param, doc for params applicable for ethernet intf

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* speed idempotence and add unittest

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* fabric_forwarding_anycast_gateway applicable for svi type intf only

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* fix speed

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 2fbfce0)
trishnaguha added a commit that referenced this pull request Mar 1, 2018
@trishnaguha
Fix nxos_interface multiple issues (#36827) (#36891)
f365374 
* fix interface_type

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* fix setting mtu, doc for state check param, doc for params applicable for ethernet intf

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* speed idempotence and add unittest

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* fabric_forwarding_anycast_gateway applicable for svi type intf only

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* fix speed

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 2fbfce0)
@trishnaguha
Copy link
Member Author

cherry-picked to 2.5

@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@dagwieers dagwieers added the cisco Cisco technologies label Feb 23, 2019
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Qalthos Qalthos Awaiting requested review from Qalthos

Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 bug This issue/PR relates to a bug. cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. networking Network category nxos Cisco NXOS community support:core This issue/PR relates to code supported by the Ansible Engineering Team. support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests.
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.

nxos_interface issues
3 participants
@trishnaguha @ansibot @dagwieers