Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue:37306 Fix issue with vlan support for onyx version 3.6.6000 #37310

Merged
merged 3 commits into from Mar 20, 2018
Merged

issue:37306 Fix issue with vlan support for onyx version 3.6.6000 #37310

merged 3 commits into from Mar 20, 2018

Conversation

samerd
Copy link
Contributor

@samerd samerd commented Mar 12, 2018

SUMMARY

Fix vlan result parsing for onyx version 3.6.6000

Fixes #37306
Add support for the new json structure returned in onyx version 3.6.6000

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

onyx_vlan.py

ANSIBLE VERSION
ansible 2.5.0 (issue/37306 c73dd67dc4) last updated 2018/03/12 17:37:13 (GMT +000)
  config file = None
  python version = 2.7.5 (default, Nov  6 2016, 00:28:07) [GCC 4.8.5 20150623 (Red Hat 4.8.5-11)]
ADDITIONAL INFORMATION

@samerd
issue:37306 Fix issue with vlan support for onyx version 3.6.6000
c73dd67 
Signed-off-by: Samer Deeb <samerd@mellanox.com>
@ansibot
Copy link
Contributor

ansibot commented Mar 12, 2018

cc @Qalthos @atabachnik @ganeshrn @gdpak @gundalow @kedarX @privateip @rcarrillocruz @trishnaguha
click here for bot help

@ansibot ansibot added bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Mar 12, 2018
@samerd
issue:37306 Fix unit-test for onyx vlan
0f67962 
Signed-off-by: Samer Deeb <samerd@mellanox.com>
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. core_review In order to be merged, this PR must follow the core review workflow. labels Mar 12, 2018
@samerd
issue:37306 Change _get_version to enables unit-test
9c8dd84 
Signed-off-by: Samer Deeb <samerd@mellanox.com>
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Mar 12, 2018
@gundalow gundalow removed the needs_triage Needs a first human triage before being processed. label Mar 12, 2018
@gundalow gundalow added this to Need CP into 2.5.1 in zzz NOT USED: Networking Bugs Mar 12, 2018
@samerd samerd mentioned this pull request Mar 13, 2018
Closed
@gundalow gundalow merged commit a89bafc into ansible:devel Mar 20, 2018
gundalow pushed a commit to gundalow/ansible that referenced this pull request Mar 20, 2018
@samerd @gundalow
issue:37306 Fix issue with vlan support for onyx version 3.6.6000 (an…
9c275c7 
…sible#37310)

* issue:37306 Fix issue with vlan support for onyx version 3.6.6000

Signed-off-by: Samer Deeb <samerd@mellanox.com>
(cherry picked from commit a89bafc)
@gundalow gundalow mentioned this pull request Mar 20, 2018
Merged
@gundalow
Copy link
Contributor

Merged into devel.
PR created for cherry-pick into stable-2.5 so this will end up in 2.5.1
#37635

@gundalow gundalow removed this from Need CP into 2.5.1 in zzz NOT USED: Networking Bugs Apr 5, 2018
gundalow added a commit that referenced this pull request Apr 5, 2018
@gundalow
issue:37306 Fix issue with vlan support for onyx version 3.6.6000 (#3…
aed8aea 
…7310) (#37635)

* issue:37306 Fix issue with vlan support for onyx version 3.6.6000

Signed-off-by: Samer Deeb <samerd@mellanox.com>
(cherry picked from commit a89bafc)
@samerd samerd deleted the issue/37306 branch August 22, 2018 19:37
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gundalow gundalow gundalow approved these changes

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. networking Network category support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

onyx_vlan throws exception when using onyx version 3.6.6000
3 participants
@samerd @ansibot @gundalow