Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue:37306 Fix issue with vlan support for onyx version 3.6.6000 (#37310) #37635

Merged
merged 1 commit into from
Apr 5, 2018
Merged

issue:37306 Fix issue with vlan support for onyx version 3.6.6000 (#37310) #37635

merged 1 commit into from
Apr 5, 2018

Conversation

gundalow
Copy link
Contributor

SUMMARY
  • issue:37306 Fix issue with vlan support for onyx version 3.6.6000

Signed-off-by: Samer Deeb samerd@mellanox.com
(cherry picked from commit a89bafc)

#37310 (review)

@samerd @gundalow
issue:37306 Fix issue with vlan support for onyx version 3.6.6000 (an…
9c275c7 
…sible#37310)

* issue:37306 Fix issue with vlan support for onyx version 3.6.6000

Signed-off-by: Samer Deeb <samerd@mellanox.com>
(cherry picked from commit a89bafc)
@gundalow gundalow added the networking Network category label Mar 20, 2018
@gundalow gundalow self-assigned this Mar 20, 2018
@gundalow gundalow added this to To Do in 2.5.x blocker list via automation Mar 20, 2018
@gundalow gundalow mentioned this pull request Mar 20, 2018
Merged
@ansibot
Copy link
Contributor

ansibot commented Mar 20, 2018

cc @Qalthos @atabachnik @ganeshrn @gdpak @kedarX @privateip @rcarrillocruz @samerd @trishnaguha
click here for bot help

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 backport This PR does not target the devel branch. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Mar 20, 2018
@gundalow gundalow added this to Need CP into 2.5.1 in zzz NOT USED: Networking Bugs Mar 20, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Mar 29, 2018
@gundalow
Copy link
Contributor Author

gundalow commented Apr 5, 2018

bot_status

@ansibot
Copy link
Contributor

ansibot commented Apr 5, 2018

Components

lib/ansible/module_utils/network/onyx/onyx.py
support: core
maintainers: Qalthos ganeshrn gdpak gundalow privateip rcarrillocruz samerd trishnaguha

lib/ansible/modules/network/onyx/onyx_vlan.py
support: community
maintainers: atabachnik samerd

test/units/modules/network/onyx/test_onyx_vlan.py
support: core
maintainers: Qalthos ganeshrn gdpak gundalow privateip rcarrillocruz trishnaguha

Metadata

waiting_on: ansible
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 0
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 1
shipit_actors (maintainers or core team members): gundalow
shipit_actors_other: []
automerge: automerge shipit test failed

click here for bot help

@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Apr 5, 2018
@gundalow gundalow merged commit aed8aea into ansible:stable-2.5 Apr 5, 2018
@gundalow gundalow deleted the backport/2.5/37310 branch April 5, 2018 11:12
@gundalow gundalow mentioned this pull request Apr 5, 2018
Merged
@gundalow gundalow removed this from To Do in 2.5.x blocker list Apr 5, 2018
@gundalow gundalow moved this from Need CP into 2.5.1 to Done in zzz NOT USED: Networking Bugs Apr 5, 2018
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@gundalow gundalow

Labels
affects_2.5 This issue/PR affects Ansible v2.5 backport This PR does not target the devel branch. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. networking Network category support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
No open projects
zzz NOT USED: Networking Bugs
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gundalow @ansibot @samerd