Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ovirt_vms: Pass correct VM entity to create method #37460

Merged
merged 1 commit into from
Mar 15, 2018
Merged

ovirt_vms: Pass correct VM entity to create method #37460

merged 1 commit into from
Mar 15, 2018

Conversation

machacekondra
Copy link
Contributor

SUMMARY

Backport of : #37249

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ovirt_vms

ANSIBLE VERSION
2.5.0rc1
ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Mar 15, 2018

cc @mwperina
click here for bot help

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. virt Virt community (incl. QEMU, KVM, libvirt, ovirt, RHV and Proxmox) owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community. labels Mar 15, 2018
@machacekondra
Copy link
Contributor Author

shipit

@samdoran samdoran added this to To Do in 2.5.x blocker list via automation Mar 15, 2018
@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Mar 15, 2018
@nitzmahone nitzmahone merged commit 9f02fea into ansible:stable-2.5 Mar 15, 2018
@nitzmahone nitzmahone moved this from To Do to Done in 2.5.x blocker list Mar 15, 2018
abadger pushed a commit that referenced this pull request Mar 19, 2018
@machacekondra @abadger
ovirt_vms: Pass correct VM entity to create method (#37460)
2e30e2c 
(cherry picked from commit 9f02fea)
abadger added a commit that referenced this pull request Mar 19, 2018
@abadger
Add changelog for #37460
3ec35b2
abadger added a commit that referenced this pull request Mar 30, 2018
@abadger
Add changelog for #37460
8f5565f
clrpackages pushed a commit to clearlinux-pkgs/ansible that referenced this pull request Apr 30, 2018
@fenrus75 @djklimes
[update to 2.5.2] Reduce recursion within group methods
12b91fc 
Abhijeet Kasurde (10):
      Fixed issue with accessing response in digital_ocean module (#37780)
      VMware: Use environment variable for connection (#37726) (#37745)
      nmcli: change default value of autoconnect (#38686)
      VMware: Set default network type as 'dhcp' (#38755)
      Correct module name in vcenter_license.py (#37672) (#37728)
      VMware: correct documentation for datacenter
      Use correct esxi host variable in vmware_cfg_backup
      VMware: handle permission denied while reading facts (#38868)
      add instanceUuid (also called PersistentId) in vmware utils (#38870)
      We need to return virtual_facts after VMWare platform detection (#39149)

Adam Dobrawy (1):
      [file] Update description of state (#38451)

Adam Miller (1):
      Backport azure_rm_image Tag fix for 2.5 (#38131) (#38228)

Adrian Likins (3):
      continue fact gathering even without dmidecode (#34925) (#38001)
      Fix redundant yaml error blurbs on ModArgs parse errors (#36923)
      Fix 'New Vault password' on vault 'edit' (#35923) (#38003)

AlanCoding (1):
      Reduce recursion within group methods

Alicia Cozine (17):
      revises network portion of 2.5 porting guide (#37938)
      Update EdgeOS modules to be community supported (#38112) (#38125)
      demonstrates best practices for group vars (#37930) (#38287)
      DOCS: Network Best Practices fixes (#38293) (#38360)
      inaugural Network FAQ (#38359) (#38703)
      corrects Junos network_cli example & variables (#38601) (#38705)
      Add details to see decrypted vault value (#37341) (#38746)
      adds FAQ TOC entry, links & examples to modules (#38706)
      avoids not-in-toc errors with :orphan:
      Fixes more rST errors (#39042)
      Link fixes (#39038)
      Internal refs (#39094)
      adds index page for roadmaps to support internal links (#39109) (#39192)
      corrects links to 'list_of' pages (#39161) (#39230)
      fixes broken links in Amazon module docs (#39248) (#39306)
      removes broken link to old module name (#39249) (#39307)
      Reduce warnings (#39254) (#39323)

Andrew Gaffney (1):
      Load plugin config defs on first load only (fixes #37553) (#37584)

Artem Tiumentcev (1):
      fix set options in callbacks for foreman

Bill Nottingham (1):
      Set `raw=True` when reading passwords from ConfigParser files. (#35582)

Brian Coca (17):
      Avoid 2nd processing of facts for actions
      restrore showing stderr on script success (#38177)
      better handling of diff key types in compose
      centralize doc/config plugin lists (#38775)
      fix displaying group vars in graph
      made missing cli tools non fatal (#37194)
      clarifying docs with first_found (#36951)
      clarify os x password with user module (#38344)
      avoid caching invetnory sources in loader (#38242)
      documented actual precedence (#38009)
      remove unused optoins from inventory cli
      show changed in online
      Ensure non ansilbe exceptions keep tracebacks (#37523)
      ensure cli dir exists before saving files to it
      make aef test more predictable
      allow incremental update for vars in loop for set_fact/include_vars (#38302)
      remove slice filter as it already exists in jinja

Chris Houseknecht (1):
      Auth method for the k8s lookup plugin now matches other modules (#37533) (#37618)

Christian Fetzer (1):
      docs: Document disabling diff on task level (#37998)

Dag Wieers (3):
      Fix nested parameters in module docs (#37793)
      Fix incorrect RN used in module (#38249)
      Clean up Grafana docs a bit (#37516)

Daniel Andrei Mincă (1):
      Fix typo in Slack Callback plugin (#38286)

David Newswanger (4):
      added nxos_smoke tests (#36647) (#37252)
      added iosxr_smoke (#37828) (#38395)
      added junos_smoke tests (#37216) (#38396)
      Add eos_smoke integration tests (#36957) (#38397)

Deepak Agrawal (2):
      Backport/2.5/37287  Eos :do not push config to device if check_mode is enabled (#38382)
      doc changes for backup option of network _config modules (#38797)

Fabian Zimmermann (1):
      fixes bug: puppet module is no longer updating persistent external facts (#38026)

Felix Fontein (2):
      Improving EC account key parsing (see #37275). (#37276)
      letsencrypt: doc: Making clearer that the module has to be executed twice, and that the second run needs the data of the first (#37884). (#38135) (#38160)

Ganesh Nalawade (10):
      eos_config module exit session gracefully (#37920)
      Fix eos_facts eapi integration test failures (#37919)
      Fix junos modules check_mode issue (#37311) (#37918)
      Add error handling for junos in case wrong connection type (#38023) (#38256)
      Fix junos transport check (#38460) (#38467)
      Add junos connection type check (#38527) (#38579)
      Add troubleshooting URL for persistent socket path related issue (#38542) (#38577)
      Fix in eos get_config cliconf api (#38682) (#38720)
      Add supported connection in junos module documentation (#38813) (#38865)
      Fix ios and iosxr terminal prompt regex (#39063) (#39089)

Izuke (1):
      Fixes #32146 Fixes reconcile inventory to correctly remove hosts from ungrouped

James Hogarth (1):
      ISSUE-37945 output not populated on failure (#37952) (#38322)

Jim Gu (1):
      yaml callback fails on python3

John R Barker (13):
      ansible_password & ansible_ssh_pass are the ENV variable (#38035) (#38324)
      fixes example address parameters (#37765) (#38328)
      nso_verify handle leaf-list in 4.5 and identityref (#37393) (#37634)
      issue:37306 Fix issue with vlan support for onyx version 3.6.6000 (#37310) (#37635)
      issue:37307 Add support for changes in pfc output in onyx 3.6.6000 (#… (#38330)
      Backport/2.5/38191 (#38327)
      Update docs to reflect support for CDP neighbors (#38051) (#38350)
      Fix the automatic docsite_pr label (#37999) (#38351)
      Backport/2.5/38386 (#38462)
      Explicitly exclude W504 (#38539) (#38550)
      issue:38321 fix onyx_config module failed while using python = 3.5 (#38343) (#38869)
      Correct formatting (#38874) (#38877)
      Modules to link relatively to docs (#39081) (#39086)

Jonas Meurer (1):
      Update porting_guide_2.5.rst (#37927)

Jordan Borean (23):
      win_certificate_store: backport fix of typo key_storage (#37862)
      Ansible.ModuleUtils.FileUtil - backport catch DirectoryNotFoundException (#37976)
      win_reboot: backport warning message arguments (#37971)
      azure_rm_networkinterface: backport no public IP fix (#37762)
      win_uri: backport fix custom header override (#37889)
      win_copy: backport 2.5 preserve local tmp path when sending multiple files (#37977)
      azure_rm_virtualmachine - backport of docs change around images supported (#37764)
      win_service: backport of special char in name handler (#38250)
      win_setup: backport Added connection name to interfaces  (#38362)
      powershell: 2.5 backport display non-ascii characters in command outputs (#38365)
      win_updates: backport 2.5 handle failure on module load (#38498)
      win_exec_wrapper: fix tests after recent change (#38504) (#38506)
      win_uri: backport 2.5 fix for when status codes are provided as a comma separated list (#38509)
      winrm: backport 2.5 added flag handler for kinit to request forwardable ticket when delegation is set (#38508)
      minor typo fix ansible/ansible#38589
      win_setup: backport 2.5 fix for machine sid to work in domains with lots of users  (#38659)
      win_updates: fix when failed is not present in output (#38856) (#38857)
      Fix typo in windows_faq.rst (#38864) (#38916)
      win_regedit: backport 2.5 stabilise tests (#38918)
      Update win_certificate_store.py (#38860) (#38927)
      Tolerate win line endings on module load 2.5 (#38919)
      Fix for win_get_url module (Fixes #39151) - 2.5 backport (#39207)
      Ansible.ModuleUtils.FileUtil - backport 2.5 Add ability to test non file system provider paths (#39203)

Loïc Blot (1):
      k8s inventory: add pod nodeport (#39107)

Lutz Reinhardt (1):
      fix bug in modules/system/user.py (#37552)

Markos Chandras (1):
      modules: zypper: Optimize the 'search' subcommand (#37191) (#37234)

Martin Krizek (4):
      Update playbooks_loops.rst (#38440) (#38475)
      Give hint when lookup fails on one element list (#38406) (#38480)
      Use correct action in warning about missing name (#38481)
      playbooks_variables.rst: fix facts code-block (#38520)

Matt Clay (7):
      Fix PEP 8 issue.
      Use new vcenter simulator container location.
      Disable failing fortios_* tests.
      Restore docker_secret test on RHEL.
      Update httptester container reference.
      Fix mysql-server install/upgrade on Ubuntu 16.04. (#39241)
      Update the cloudstack test container reference.

Matt Davis (6):
      re-sort unified RPM changelog
      pick up missing plugin docs boolean coercion backport
      add missing to_bytes import in interfaces_file
      fix RPM builds when REPOTAG is not defined
      New release v2.5.1
      New release v2.5.2

Matt Martz (10):
      Backport #37646 for 2.5 (#37653)
      Backport #37881 for 2.5.1 (#37937)
      Backport #36372 for 2.5 (#37666)
      Backport #38194 for 2.5 - include_vars error fix (#38225)
      Backport #38884 for 2.5 - docker/docker-py guard (#38889)
      Backport #37083 for 2.5 - IncludedFile comparison fix for free strategy (#38981)
      Backport #38827 for 2.5 - Allow inheriting attrs from static parents (#38847)
      Backport #38747 for 2.5 - Block copy and reparenting improvements (#38829)
      Add changelog for #38302
      Documentation for query/q. Fixes #38275 (#38558) (#39316)

Nathaniel Case (3):
      Network connection backports (#37529)
      fixes issue when netconf would report ios is not supported (#38155) (#38240)
      Fall back to ValueError if JSONDecodeError is not available (#38276) (#38423)

Olivier Bourdon (1):
      Fix interfaces_file for proper file contents (#37818)

Ondra Machacek (2):
      ovirt: Cherry picks of recent fixes to devel branch (#38341)
      Backports to 2.5 of recent oVirt fixes (#38835)

Pilou (1):
      module_common: handle None value for templar (#36651)

Renato Orgito (1):
      Have the ios_interface module include CDP when checking neighbors (#38046)

Rene Moser (3):
      Fixing domain to authorization matching for ACME v2. (#37558) (#37572)
      cs_vpc_offering: listVPCOffering API returns any matching names (#37783) (#37832)
      cloudstack: do not rely on APIs list queries for names (#37910) (#38014)

Ricardo Carrillo Cruz (1):
      Cherry pick 35568 (#38347)

Rémy Léone (1):
      Fix deprecated warnings

Sam Doran (5):
      Doc build warning/broken link clean-a-palooza (#37382) (#38185)
      Update installation docs for RHEL based distributions. (#38053)
      Fix edgeos_config: {backup: yes} (#37619) (#37733)
      Add changelog entry
      fixed documentation to include esxi host (#38668) (#38673)

Sloane Hertel (1):
      [cloud] Add AWSRetry to ec2_vpc_net and ec2_vpc_dhcp_option to stabilize return values (#36264) (#38975)

Stephen Weber (1):
      Convert README from Markdown to ReStructured Text and use as longdesc (#22330)

Sudheer Satyanarayana (1):
      Clarify recursive

Sviatoslav Sydorenko (7):
      Add docs badge to README
      Add a list or extra URLs to distribution metadata
      Update python requirements in distribution meta
      Shield setup module from accidental setup exec
      Refactor setup.py helper code
      Suppress a UserWarning about unknown dist option
      Upgrade PYPI badge to point to new Warehouse site

Toshio Kuratomi (23):
      Bkprt py3 haproxy (#37791)
      Py3 vargrant inv (#37803)
      Bkprt py3 jira (#37800)
      Bkprt py3 csvfile (#37665)
      Bkprt py3 ec2 user data (#37664)
      Bkprt py3 pull fix (#37663)
      Add changelog for ansible/ansible#37460
      Document that this module was renamed recently (#37420) (#37422)
      The ssh change note has been removed
      Removes modules from TOC, speeding up build time and reducing doc disk space requirements. (#38428)
      Bkprt py3 consul kv (#37802)
      README.md was renamed.  Fix deb build reference to the README
      When I rebased the README as rst PR, I missed a few changes.
      Add changelog entry for grafana base64 port
      Add alias's as a :ref: target for modules
      Modules that have a link to their own deprecated section need to use a different link syntax (#38697)
      Fix places in docs that refer to modules without namespace
      Some more fixes for the docs :ref: disambiguation
      Fixes for multiline doc descriotions breaking rst formatting
      Update info on python support (#38855)
      Fix copy to only follow symlinks for files in the non-recursive case
      Add note about the dangers of ANSIBLE_DEBUG (#39261)
      Winrm encoding in exception fix (#39333)

Trishna Guha (5):
      nxos bugfixes cherry-pick  (#38091)
      stable-2.5 nxos bugfix cherry-pick (#38372)
      nxos_igmp and nxos_hsrp fix (#38513)
      nxos_igmp_snooping fix cherry-pick (#38596)
      nxos bugfixes cherry-pick (#38950)

Will Thames (4):
      [cloud]Ensure SGs in default VPCs get default egress rule (#38018)
      Use a temp directory that is more likely to exist (#38645)
      [AWS cloudfront_distribution] Update minimum protocol versions (#38644) (#38990)
      elb_target_group: use port parameter as default for target port (#38578) (#38992)

msven (1):
      ec2_asg: fix #28087 and #35993 (#36679)

mwpeterson (1):
      Update test-module (#39331)

pcahyna (1):
      File module: correct description of "state" (#36327)

s-hertel (1):
      add changelog

scottb (9):
      Fixes scrolling issue without breaking header nav (#37864)
      Adds VMWare to TOC; sort scenario guides alphabetically (#38238)
      Reinstated element to fix doc display on mobile devices. (#38246)
      Fixes CSS so docs display properly on mobile (#38373)
      Additional docs CSS fix for mobile (#38376)
      Tweaks docs CSS to fix minor issue with main content page display cutting off at the bottom. (#38432) (#38434)
      Mobile CSS update - adds scrolling inertia (#38443) (#38445)
      [WIP] disambiguating autogenerated module docs attempted fix of #38439. (#38890)
      Reinstate code of conduct to the community TOC; add links to code of conduct to a few conspicuous spots in the community guide. (#38501)
@dagwieers dagwieers added ovirt oVirt and RHV community and removed virt Virt community (incl. QEMU, KVM, libvirt, ovirt, RHV and Proxmox) labels Feb 21, 2019
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. ovirt oVirt and RHV community owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community.
Projects
No open projects
2.5.x blocker list
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@machacekondra @ansibot @dagwieers @samdoran @nitzmahone