ovirt_vms: Pass correct VM entity to create method #37249
Merged
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
bug
s-hertel
removed
the
needs_triage
|
Btw, we should backport to 2.5.1, right? |
ansibot
added
automerge
gerrit-ovirt-org
pushed a commit
to oVirt/ovirt-hosted-engine-setup
that referenced
this pull request
Mar 12, 2018
Backport ansible/ansible#37249 Change-Id: I7f6e740cfd9d23157b26311545f37a8372f14d7a Bug-Url: https://bugzilla.redhat.com/1549082 Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
gerrit-ovirt-org
pushed a commit
to oVirt/ovirt-hosted-engine-setup
that referenced
this pull request
Mar 12, 2018
Backport ansible/ansible#37249 Change-Id: I7f6e740cfd9d23157b26311545f37a8372f14d7a Bug-Url: https://bugzilla.redhat.com/1549082 Signed-off-by: Simone Tiraboschi <stirabos@redhat.com> (cherry picked from commit 92d5a2a)
privateip
added a commit
that referenced
this pull request
Mar 13, 2018
This reverts commit c5c78ab.
dagwieers
added
ovirt
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
When user is using following task:
we fail on:
{'changed': False, u'exception': u'Traceback (most recent call last):\n File "/tmp/ansible_j18cwF/ansible_module_ovirt_vms.py", line 1909, in main\n clone_permissions=module.par {u'vmstop_result': {u'msg': u"'NoneType' object has no attribute 'enabled'", u'failed': True, u'exce.__doc__: "dict() -> new empty dictionary\ndict(mapping) -> new dictionary initialized from a mapping object's\n (key, value) pairs\ndict(iterable) -> new dictionary initialized as if via:\n d = {}\n for k, v in iterable:\n d[k] = v\ndict(**kwargs) -> new dictionary initialized with the name=value pairs\n in the keyword argument list. For example: dict(one=1, two=2)" {u'vmstop_result': {u'msg': u"'NoneType' object has no attribute 'enabled'", u'failed': True, u'exce.__hash__: NoneISSUE TYPE
COMPONENT NAME
ovirt_vms
ANSIBLE VERSION
ADDITIONAL INFORMATION