Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

have the ios_interface module include CDP when checking neighbors #37655

Closed
orgito opened this issue Mar 20, 2018 · 2 comments · Fixed by #37667
Closed

have the ios_interface module include CDP when checking neighbors #37655

orgito opened this issue Mar 20, 2018 · 2 comments · Fixed by #37667
Labels
affects_2.4 This issue/PR affects Ansible v2.4 cisco Cisco technologies feature This issue/PR relates to a feature request. ios Cisco IOS community module This issue/PR relates to a module. networking Network category support:network This issue/PR relates to code supported by the Ansible Network Team.

Comments

@orgito
Copy link
Contributor

orgito commented Mar 20, 2018 •
edited

ISSUE TYPE
  • Feature Idea
COMPONENT NAME

ios_interface

ANSIBLE VERSION
ansible 2.6
SUMMARY

Currently ios_interface only check for neighbors using the LLDP protocol. Many environments only have the CDP protocol enabled.

The suggestion is to also include CDP neighbors when cheking neighbors intent. It could be done with a different option if you think is more appropriate. IMO using both protocols would be simpler.

STEPS TO REPRODUCE

Run a simple playbook using neighbors intent parameters

- name: Check neighbors intent arguments
  ios_interface:
    name: Gi0/0
    neighbors:
    - port: eth0
      host: netdev
EXPECTED RESULTS

Should check CDP and LLDP neighbors

ACTUAL RESULTS

Only checks LLDP neighbors
@ansibot
Copy link
Contributor

ansibot commented Mar 20, 2018

Files identified in the description:

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Mar 20, 2018

cc @ganeshrn @privateip @rcarrillocruz
click here for bot help

@ansibot ansibot added affects_2.4 This issue/PR affects Ansible v2.4 feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category support:network This issue/PR relates to code supported by the Ansible Network Team. labels Mar 20, 2018
orgito added a commit to orgito/ansible that referenced this issue Mar 20, 2018
@orgito
Add CDP support for the neighbors option (ansible#37655)
0f90853
@orgito orgito mentioned this issue Mar 20, 2018
Merged
@webknjaz webknjaz removed the needs_triage Needs a first human triage before being processed. label Mar 20, 2018
ganeshrn pushed a commit that referenced this issue Mar 27, 2018
@orgito @ganeshrn
Add CDP support for the neighbors option (#37655) (#37667)
023f130
orgito added a commit to orgito/ansible that referenced this issue Mar 28, 2018
@orgito
Add CDP support for the neighbors option (ansible#37655)
8799bab 
(cherry picked from commit 0f90853)
@orgito orgito mentioned this issue Mar 28, 2018
Merged
ryancurrah pushed a commit to ryancurrah/ansible that referenced this issue Apr 4, 2018
@orgito @ryancurrah
Add CDP support for the neighbors option (ansible#37655) (ansible#37667)
e7b2954
gundalow pushed a commit that referenced this issue Apr 5, 2018
@orgito @gundalow
Have the ios_interface module include CDP when checking neighbors (#3…
4e3e2c7 
…8046)

* Add CDP support for the neighbors option (#37655)

(cherry picked from commit 0f90853)

* Add ios_interface CDP support to changelog
@dagwieers dagwieers added ios Cisco IOS community cisco Cisco technologies labels Mar 5, 2019
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
affects_2.4 This issue/PR affects Ansible v2.4 cisco Cisco technologies feature This issue/PR relates to a feature request. ios Cisco IOS community module This issue/PR relates to a module. networking Network category support:network This issue/PR relates to code supported by the Ansible Network Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

have the ios_interface module include CDP when checking neighbors (#37655) orgito/ansible
4 participants
@dagwieers @webknjaz @orgito @ansibot