Adding exos_command cli_conf module #37775

rdvencioneck · 2018-03-22T13:11:51Z

SUMMARY

This PR adds suport for running "read-only" commands on Extreme OS (EXOS)

ISSUE TYPE

New Module Pull Request

COMPONENT NAME

exos_command

ansibot · 2018-03-22T13:17:30Z

cc @Qalthos @ganeshrn @gdpak @gundalow @privateip @rcarrillocruz @trishnaguha
click here for bot help

ansibot · 2018-03-22T13:43:36Z

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/network/exos/exos_command.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/network/exos/exos_command.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/network/exos/exos_command.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/network/exos/exos_command.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/network/exos/exos_command.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test boilerplate [explain] failed with 2 errors:

lib/ansible/modules/network/exos/exos_command.py:0:0: missing: __metaclass__ = type
lib/ansible/modules/network/exos/exos_command.py:0:0: missing: from __future__ import (absolute_import, division, print_function)

The test ansible-test sanity --test pep8 [explain] failed with 6 errors:

lib/ansible/module_utils/network/exos/exos.py:36:1: E302 expected 2 blank lines, found 1
lib/ansible/module_utils/network/exos/exos.py:60:1: E302 expected 2 blank lines, found 1
lib/ansible/module_utils/network/exos/exos.py:63:1: E302 expected 2 blank lines, found 1
lib/ansible/module_utils/network/exos/exos.py:75:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/network/exos/exos_command.py:167:21: E128 continuation line under-indented for visual indent
lib/ansible/plugins/cliconf/exos.py:31:1: E302 expected 2 blank lines, found 1

The test ansible-test sanity --test validate-modules [explain] failed with 2 errors:

lib/ansible/modules/network/exos/exos_command.py:0:0: E304 Unknown DOCUMENTATION error, see TRACE: argument of type 'NoneType' is not iterable
lib/ansible/modules/network/exos/exos_command.py:0:0: E316 ANSIBLE_METADATA.metadata_version: not a valid value for dictionary value @ data['metadata_version']. Got '1.0'

click here for bot help

ansibot · 2018-03-22T15:25:09Z

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/network/exos/exos_command.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/network/exos/exos_command.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/network/exos/exos_command.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/network/exos/exos_command.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/network/exos/exos_command.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test boilerplate [explain] failed with 2 errors:

lib/ansible/modules/network/exos/exos_command.py:0:0: missing: __metaclass__ = type
lib/ansible/modules/network/exos/exos_command.py:0:0: missing: from __future__ import (absolute_import, division, print_function)

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/network/exos/exos_command.py:0:0: E304 Unknown DOCUMENTATION error, see TRACE: argument of type 'NoneType' is not iterable

click here for bot help

ganeshrn · 2018-04-09T03:43:19Z

lib/ansible/module_utils/network/exos/exos.py

+    return module._exos_capabilities
+
+
+def check_args(module, warnings):


This function is not required.

ganeshrn · 2018-04-09T03:45:05Z

lib/ansible/modules/network/exos/exos_command.py

+module: exos_command
+version_added: "2.6"
+author: "Rafael D. Vencioneck (@rdvencioneck)"
+short_description: Run commands on remote devices running EXOS


Please include the company name in the short_description to make it easier for people to find the modules
See http://docs.ansible.com/ansible/latest/modules/list_of_network_modules.html

ganeshrn · 2018-04-09T03:45:49Z

lib/ansible/modules/network/exos/exos_command.py

+        before moving forward. If the conditional is not true
+        within the configured number of retries, the task fails.
+        See examples.
+    required: false


required: false lines can be removed, as that's the default

ganeshrn · 2018-04-09T03:46:42Z

lib/ansible/modules/network/exos/exos_command.py

+        See examples.
+    required: false
+    default: null
+    aliases: ['waitfor']


waitfor is an old name and not required to be added to new modules. This line can be removed.

ganeshrn · 2018-04-09T03:47:57Z

lib/ansible/modules/network/exos/exos_command.py

+    argument_spec = dict(
+        commands=dict(type='list', required=True),
+
+        wait_for=dict(type='list', aliases=['waitfor']),


aliases can be removed

rdvencioneck · 2018-04-11T03:17:32Z

@ganeshrn thank you for your review! I'm committing the requested changes right now.

…tion

ganeshrn

Please update the new files added in this PR https://github.com/ansible/ansible/blob/devel/.github/BOTMETA.yml along with your GitHub handle

* Adding exos_command cli_conf module * fixing documentation, indentation and metadata_version * removing doc fragmentation and adding required import * removing unnecessary code and including company name on short_description * updating BOTMETA.yml with exos module information

Adding exos_command cli_conf module

7e30786

ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Mar 22, 2018

fixing documentation, indentation and metadata_version

faee9ec

samdoran removed the needs_triage Needs a first human triage before being processed. label Mar 22, 2018

removing doc fragmentation and adding required import

048f3ab

ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Mar 30, 2018

calfonso added this to the 2.6.0 milestone Apr 2, 2018

ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Apr 2, 2018

ganeshrn reviewed Apr 9, 2018

View reviewed changes

removing unnecessary code and including company name on short_descrip…

4943912

…tion

ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Apr 11, 2018

ganeshrn approved these changes Apr 12, 2018

View reviewed changes

updating BOTMETA.yml with exos module information

41c1b52

ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Apr 20, 2018

ganeshrn merged commit 0d1e9bf into ansible:devel Apr 23, 2018

LindsayHill mentioned this pull request May 3, 2018

Support for EXOS extremenetworks/ansible-extreme#4

Closed

dagwieers added the botmeta This PR modifies the BOTMETA.yml and this requires special attention! label Feb 21, 2019

ansible locked and limited conversation to collaborators Apr 27, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding exos_command cli_conf module #37775

Adding exos_command cli_conf module #37775

rdvencioneck commented Mar 22, 2018

ansibot commented Mar 22, 2018

ansibot commented Mar 22, 2018

ansibot commented Mar 22, 2018

ganeshrn Apr 9, 2018

ganeshrn Apr 9, 2018

ganeshrn Apr 9, 2018

ganeshrn Apr 9, 2018

ganeshrn Apr 9, 2018

rdvencioneck commented Apr 11, 2018

ganeshrn left a comment

		return module._exos_capabilities


		def check_args(module, warnings):

Adding exos_command cli_conf module #37775

Adding exos_command cli_conf module #37775

Conversation

rdvencioneck commented Mar 22, 2018

SUMMARY

ISSUE TYPE

COMPONENT NAME

ansibot commented Mar 22, 2018

ansibot commented Mar 22, 2018

ansibot commented Mar 22, 2018

ganeshrn Apr 9, 2018

Choose a reason for hiding this comment

ganeshrn Apr 9, 2018

Choose a reason for hiding this comment

ganeshrn Apr 9, 2018

Choose a reason for hiding this comment

ganeshrn Apr 9, 2018

Choose a reason for hiding this comment

ganeshrn Apr 9, 2018

Choose a reason for hiding this comment

rdvencioneck commented Apr 11, 2018

ganeshrn left a comment

Choose a reason for hiding this comment