Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrongly ordered deprecation warning for win_reboot #37891

Closed
trondhindenes opened this issue Mar 25, 2018 · 3 comments · Fixed by #37898
Closed

Wrongly ordered deprecation warning for win_reboot #37891

trondhindenes opened this issue Mar 25, 2018 · 3 comments · Fixed by #37898
Labels
affects_2.5 This issue/PR affects Ansible v2.5 bug This issue/PR relates to a bug. module This issue/PR relates to a module. support:core This issue/PR relates to code supported by the Ansible Engineering Team. windows Windows community

Comments

@trondhindenes
Copy link
Contributor

ISSUE TYPE
  • Bug Report
COMPONENT NAME

win_reboot

ANSIBLE VERSION
2.5.0
SUMMARY

I get this message:
[WARNING]: Since Ansible shutdown_timeout_sec, 2.5 is no longer used with win_reboot
Pretty sure it should have been:
[WARNING]: Since Ansible 2.5, shutdown_timeout_sec is no longer used with win_reboot
@ansibot
Copy link
Contributor

ansibot commented Mar 25, 2018

Files identified in the description:

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Mar 25, 2018

cc @dagwieers @jborean93 @jhawkesworth @nitzmahone
click here for bot help

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 bug This issue/PR relates to a bug. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. windows Windows community labels Mar 25, 2018
@jborean93 jborean93 mentioned this issue Mar 26, 2018
Merged
@jborean93
Copy link
Contributor

Thanks for the report @trondhindenes, I've raised a PR to fix this here #37898

@jborean93 jborean93 removed the needs_triage Needs a first human triage before being processed. label Mar 26, 2018
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 bug This issue/PR relates to a bug. module This issue/PR relates to a module. support:core This issue/PR relates to code supported by the Ansible Engineering Team. windows Windows community
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

win_reboot: fixed up warning message for dep args jborean93/ansible
3 participants
@trondhindenes @ansibot @jborean93