Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

win_reboot: fixed up warning message for dep args #37898

Merged
merged 1 commit into from Mar 27, 2018
Merged

win_reboot: fixed up warning message for dep args #37898

merged 1 commit into from Mar 27, 2018

Conversation

jborean93
Copy link
Contributor

SUMMARY

Fixes the win_reboot action plugin to correct display the arg and version in the right order when a deprecated argument is used.

Fixes #37891

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

win_reboot

ANSIBLE VERSION
devel
2.5

@jborean93 jborean93 mentioned this pull request Mar 26, 2018
Closed
@ansibot ansibot added bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Mar 26, 2018
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Mar 26, 2018
@jborean93
Copy link
Contributor Author

Error is unrelated to the change.

@jborean93 jborean93 merged commit c4e7b54 into ansible:devel Mar 27, 2018
@jborean93 jborean93 deleted the win_reboot-warning-fix branch March 27, 2018 03:04
jborean93 added a commit to jborean93/ansible that referenced this pull request Mar 27, 2018
@jborean93
win_reboot: fixed up warning message for dep args (ansible#37898)
af53d30 
(cherry picked from commit c4e7b54)
@jborean93 jborean93 mentioned this pull request Mar 27, 2018
Merged
@jborean93
Copy link
Contributor Author

Backport PR to stable-2.5 #37971

jborean93 added a commit that referenced this pull request Apr 2, 2018
@jborean93
win_reboot: backport warning message arguments (#37971)
c056b8a 
* win_reboot: fixed up warning message for dep args (#37898)

(cherry picked from commit c4e7b54)

* Added changelog fragment
ryancurrah pushed a commit to ryancurrah/ansible that referenced this pull request Apr 4, 2018
@jborean93 @ryancurrah
win_reboot: fixed up warning message for dep args (ansible#37898)
d8dc72f
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
bug This issue/PR relates to a bug. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrongly ordered deprecation warning for win_reboot
3 participants
@jborean93 @sivel @ansibot