Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix nxos_hsrp issues #38410

Merged
merged 3 commits into from Apr 10, 2018
Merged

fix nxos_hsrp issues #38410

merged 3 commits into from Apr 10, 2018

Conversation

saichint
Copy link
Contributor

@saichint saichint commented Apr 6, 2018 •
edited

SUMMARY

fixes #38409

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

nxos_hsrp

ANSIBLE VERSION
ansible 2.6.0 (devel fed20b825f) last updated 2018/02/15 12:51:12 (GMT -400)
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /root/agents-ci/ansible/lib/ansible
  executable location = /root/agents-ci/ansible/bin/ansible
  python version = 2.7.6 (default, Oct 26 2016, 20:30:19) [GCC 4.8.4]
ADDITIONAL INFORMATION
  • This PR fixes nxos_hsrp issues #38409
  • Removed dead code
  • Integration tests enhanced for changes in configuration, defaults and idempotent checks.
  • Tested on all platforms and they pass

@ansibot
Copy link
Contributor

ansibot commented Apr 6, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/network/nxos/nxos_hsrp.py:0:0: E324 Value for "default" from the argument_spec (None) for "preempt" does not match the documentation ('disabled')

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Apr 6, 2018

cc @GGabriele @Qalthos @ganeshrn @gdpak @gundalow @jedelman8 @mikewiebe @privateip @rahushen @rcarrillocruz @trishnaguha
click here for bot help

@ansibot ansibot added bug This issue/PR relates to a bug. ci_verified Changes made in this PR are causing tests to fail. module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. networking Network category nxos Cisco NXOS community support:core This issue/PR relates to code supported by the Ansible Engineering Team. support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests. labels Apr 6, 2018
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Apr 6, 2018
@s-hertel s-hertel removed the needs_triage Needs a first human triage before being processed. label Apr 6, 2018
@trishnaguha trishnaguha self-assigned this Apr 9, 2018
@trishnaguha trishnaguha added this to the 2.5.0 milestone Apr 9, 2018
trishnaguha
trishnaguha reviewed Apr 9, 2018
View reviewed changes
lib/ansible/modules/network/nxos/nxos_hsrp.py
should be 7 followed by the key string. Otherwise, it can be 0 followed by
key string or just key string (for backward compatibility). For text type,
this should be just be a key string. if this is 'default', authentication
is removed.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add example for md5 authentication with '7' or '0' auth_string in the Example section?
otherwise auth encryption can be confused as new parameter.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added examples, thanks for pointing this out.

@trishnaguha trishnaguha merged commit dabe5e6 into ansible:devel Apr 10, 2018
@trishnaguha trishnaguha added this to Need CP into 2.5.1 in zzz NOT USED: Networking Bugs Apr 10, 2018
trishnaguha pushed a commit to trishnaguha/ansible that referenced this pull request Apr 10, 2018
@trishnaguha
fix nxos_hsrp issues (ansible#38410)
28212e2 
* fix nxos_hsrp issues

* shippable fix

* add examples for md5 auth

(cherry picked from commit dabe5e6)
@trishnaguha trishnaguha moved this from Need CP into 2.5.1 to Done in zzz NOT USED: Networking Bugs Apr 10, 2018
trishnaguha added a commit that referenced this pull request Apr 10, 2018
@trishnaguha
nxos_igmp and nxos_hsrp fix (#38513)
7f55954 
* fix nxos_igmp issues (#38496)

(cherry picked from commit 361437b)

* fix nxos_hsrp issues (#38410)

* fix nxos_hsrp issues

* shippable fix

* add examples for md5 auth

(cherry picked from commit dabe5e6)

* update changelog

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
@saichint saichint deleted the hsrp branch April 10, 2018 15:28
ilicmilan pushed a commit to ilicmilan/ansible that referenced this pull request Nov 7, 2018
@ilicmilan
fix nxos_hsrp issues (ansible#38410)
00c2d78 
* fix nxos_hsrp issues

* shippable fix

* add examples for md5 auth
@dagwieers dagwieers added the cisco Cisco technologies label Feb 23, 2019
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@trishnaguha trishnaguha trishnaguha approved these changes

Assignees

@trishnaguha trishnaguha

Labels
bug This issue/PR relates to a bug. cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. networking Network category nxos Cisco NXOS community support:core This issue/PR relates to code supported by the Ansible Engineering Team. support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests.
Projects
No open projects
zzz NOT USED: Networking Bugs
  
Done
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.

nxos_hsrp issues
5 participants
@saichint @ansibot @trishnaguha @dagwieers @s-hertel