Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oVirt disks module: exception 'NoneType' object has no attribute 'status' #38661

Closed
mykaul opened this issue Apr 12, 2018 · 3 comments · Fixed by #38726
Closed

oVirt disks module: exception 'NoneType' object has no attribute 'status' #38661

mykaul opened this issue Apr 12, 2018 · 3 comments · Fixed by #38726
Labels
affects_2.5 This issue/PR affects Ansible v2.5 bug This issue/PR relates to a bug. cloud deprecated This issue/PR relates to a deprecated module. module This issue/PR relates to a module. ovirt oVirt and RHV community support:community This issue/PR relates to code supported by the Ansible community.

Comments

@mykaul
Copy link
Contributor

mykaul commented Apr 12, 2018 •
edited by Akasurde

ISSUE TYPE
  • Bug Report
COMPONENT NAME

ansible_module_ovirt_disks

ANSIBLE VERSION
ansible-2.5.0-2.el7.noarch
CONFIGURATION
OS / ENVIRONMENT

CentOS 7.4

SUMMARY
The full traceback is:
Traceback (most recent call last):
  File "/tmp/ansible_JGGvK7/ansible_module_ovirt_disks.py", line 619, in main
    fail_condition=lambda d: d.status == otypes.DiskStatus.ILLEGAL,
  File "/tmp/ansible_JGGvK7/ansible_modlib.zip/ansible/module_utils/ovirt.py", line 601, in create
    poll_interval=self._module.params['poll_interval'],
  File "/tmp/ansible_JGGvK7/ansible_modlib.zip/ansible/module_utils/ovirt.py", line 330, in wait
    elif fail_condition(entity):
  File "/tmp/ansible_JGGvK7/ansible_module_ovirt_disks.py", line 619, in <lambda>
    fail_condition=lambda d: d.status == otypes.DiskStatus.ILLEGAL,
AttributeError: 'NoneType' object has no attribute 'status'
STEPS TO REPRODUCE



EXPECTED RESULTS



ACTUAL RESULTS







      		
    

      
  





        

            

            

              
            

        

      


      
    








      

    



      

  
      



  

  @ansibot





  


    

      

  

    

        
    
    

  


      
          
    
            Copy link

      
    

  


  

      

      

  
    Contributor


      

  


  

    

      

      
          ansibot
  

      

      

      commented


        Apr 12, 2018


      
    


  





      


        


  
    

      
          
Files identified in the description:



If these files are inaccurate, please update the component name section of the description or use the !component bot command.


click here for bot help


      		
    

  





        


            

              
            

        

      


      

            
  

    
  
  

  

  



    












      

  
      



  

  @ansibot





  


    

      

  

    

        
    
    

  


      
          
    
            Copy link

      
    

  


  

      

      

  
    Contributor


      

  


  

    

      

      
          ansibot
  

      

      

      commented


        Apr 12, 2018


      
    


  





      


        


  
    

      
          
cc @machacekondra @mwperina

click here for bot help


      		
    

  





        


            

              
            

        

      


      

            
  

    
  
  

  

  



    












      

  
          

  

    
  

  


    

        @ansibot
ansibot




          added
      

  affects_2.5

  This issue/PR affects Ansible v2.5

      

  bug

  This issue/PR relates to a bug.

      

  cloud


      

  deprecated

  This issue/PR relates to a deprecated module.

      

  module

  This issue/PR relates to a module.

      

  needs_triage

  Needs a first human triage before being processed.

      

  virt

  Virt community (incl. QEMU, KVM, libvirt, ovirt, RHV and Proxmox)

      

  support:community

  This issue/PR relates to code supported by the Ansible community.

  labels


    Apr 12, 2018

  










      

  
      



  

  @mykaul





  


    

      

  

    

        
    
    

  


      
          
    
            Copy link

      
    

  


  

      

      

  
    Contributor


      

  Author


  


  

    

      

      
          mykaul
  

      

      

      commented


        Apr 12, 2018


      
    


  





      


        


  
    

      
          
This seems to happen only when the storage domain is iSCSI - it worked OK with NFS!

      		
    

  





        


            

              
            

        

      


      

            
  

    
  
  

  

  



    












      

  
          

  

    
  

  


    

        @samdoran
samdoran




        removed
  the 

  needs_triage

  Needs a first human triage before being processed.
 label


    Apr 12, 2018

  





  


  
    
  
  

    
  machacekondra 

      added a commit
        to machacekondra/ansible
      that referenced
      this issue

    
      Apr 13, 2018
    
    

      


  

    

      


  

      
        @machacekondra
  





      

        
          ovirt_disks: Fix fail condition for LUN disk
        

          
            
          

      


      

          

    
    
    

  

      


      

      


      
      

        
          0e12549
        
      

    

  

    

      
Fixes: ansible#38661

    




    

  




  

  

    
  


  

      

    @machacekondra
machacekondra



    mentioned this issue
    
      Apr 13, 2018
    





  


  

      
   Merged

  







  




  

  


  


  
    
  
  

    
  ansibot 

      pushed a commit
      that referenced
      this issue

    
      Apr 13, 2018
    
    

      


  

    

      


  

      
        @machacekondra
      
        @ansibot
  





      

        
          ovirt_disks: Fix fail condition for LUN disk (#38726)
        

          
            
          

      


      

          

    
    
    

  

      


      

      


      
      

        
          efa7ebb
        
      

    

  

    

      
Fixes: #38661

    




    

  




  
  


  
    
  
  

    
  machacekondra 

      added a commit
        to machacekondra/ansible
      that referenced
      this issue

    
      Apr 26, 2018
    
    

      


  

    

      


  

      
        @machacekondra
  





      

        
          ovirt_disks: Fix fail condition for LUN disk
        

          
            
          

      


      

          

    
    
    

  

      


      

      


      
      

        
          ccc5dbb
        
      

    

  

    

      
Fixes: ansible#38661

    




    

  




  


  
    
  
  

    
  ryansb 

      pushed a commit
      that referenced
      this issue

    
      Apr 26, 2018
    
    

      


  

    

      


  

      
        @machacekondra
      
        @ryansb
  





      

        
          Backports to 2.5 of recent oVirt fixes (#38835)
        

          
            
          

      


      

          

    
    
    

  

      


      

      


      
      

        
          757fb52
        
      

    

  

    

      
* ovirt_disks: Fix fail condition for LUN disk

Fixes: #38661

* ovirt_host_networks: Fix removing of network attachments

* ovirt: Support removing unmanaged networks

* ovirt: FCP storage domains don't have to have target

    




    

  




  
  
  
  
  


  
    
  
  

    
  ilicmilan 

      pushed a commit
        to ilicmilan/ansible
      that referenced
      this issue

    
      Nov 7, 2018
    
    

      


  

    

      


  

      
        @machacekondra
      
        @ilicmilan
  





      

        
          ovirt_disks: Fix fail condition for LUN disk (ansible#38726)
        

          
            
          

      


      

          

    
    
    

  

      


      

      


      
      

        
          8e78313
        
      

    

  

    

      
Fixes: ansible#38661

    




    

  




  

  

    
  

  


    

        @dagwieers
dagwieers




          added
      

  ovirt

  oVirt and RHV community

    and removed
      

  virt

  Virt community (incl. QEMU, KVM, libvirt, ovirt, RHV and Proxmox)

  labels


    Feb 28, 2019

  





  

  

    
  

  


    

        @ansible
ansible




      locked and limited conversation to collaborators


    Apr 27, 2019

  














  
  

    

      

  





  




  
  

             

  
      Sign up for free
      to subscribe to this conversation on GitHub.
      Already have an account?
      Sign in.


  


  






  
                  




    

  


      
  

    Assignees
  



        

    No one assigned







      


  


  

    Labels
  



    

      

    affects_2.5

  This issue/PR affects Ansible v2.5
  

    bug

  This issue/PR relates to a bug.
  

    cloud

  

    deprecated

  This issue/PR relates to a deprecated module.
  

    module

  This issue/PR relates to a module.
  

    ovirt

  oVirt and RHV community
  

    support:community

  This issue/PR relates to code supported by the Ansible community.








      

  

    

        

    Projects
  


        




    None yet




  



      

  

    
  

    Milestone
  


      No milestone





    
      
          


  

    
      

        
    

    Development
  




            
Successfully merging a pull request may close this issue.





    


  
          
      ovirt_disks: Fix fail condition for LUN disk

    
      machacekondra/ansible
    





    
  




        
      

    

  
      

  

    

      4 participants
    

    

        
          @dagwieers 
        
          @samdoran 
        
          @mykaul 
        
          @ansibot