Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

win_updates: fix when failed is not present in output #38856

Merged
merged 1 commit into from
Apr 17, 2018

Conversation

jborean93
Copy link
Contributor

SUMMARY

In an attempt to fix up a previous update I made things worse. This gets the failed key with a default of False. If also checks if updates is in the result key where it should always be unless a major issue occurred.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

win_updates

ANSIBLE VERSION
devel
2.5

@ansibot ansibot added bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Apr 17, 2018
@jborean93 jborean93 merged commit f1c1643 into ansible:devel Apr 17, 2018
@jborean93 jborean93 deleted the win_updates-failed-fix branch April 17, 2018 00:45
jborean93 added a commit to jborean93/ansible that referenced this pull request Apr 17, 2018
@jborean93
Copy link
Contributor Author

Backport PR to stable-2.5 #38857

jborean93 added a commit that referenced this pull request Apr 17, 2018
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Apr 17, 2018
ilicmilan pushed a commit to ilicmilan/ansible that referenced this pull request Nov 7, 2018
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue/PR relates to a bug. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants