win_updates: handle if module failed to run

[jborean93]

SUMMARY

If the win_updates module fails to run at all or an unhandled exception, the action plugin will just return the message instead of trying to continue.

Somewhat Fixes #38232

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

win_updates

ANSIBLE VERSION

devel
2.5

[jborean93]

Backport PR to stable-2.5 #38498

[macampo]

We encounter the same bug. I updated our win_updates.py with your changes and the error we got back now has changed to:
{
"msg": "Unexpected failure during module execution.",
"exception": "Traceback (most recent call last):\n File "/usr/lib/python2.7/site-packages/ansible/executor/task_executor.py", line 138, in run\n res = self._execute()\n File "/usr/lib/python2.7/site-packages/ansible/executor/task_executor.py", line 554, in _execute\n result = self._handler.run(task_vars=variables)\n File "/usr/lib/python2.7/site-packages/ansible/plugins/action/win_updates.py", line 192, in run\n if result['failed']:\nKeyError: 'failed'\n",
"stdout": ""
}

I'm happy to work on this issue together, because when it is fixed it will save me quite some time.

[svpudik]

Hello I have same issue on a lot of servers this module failing. We are using ansible 2.5

The full traceback is:
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/ansible/executor/task_executor.py", line 138, in run
res = self._execute()
File "/usr/lib/python2.7/site-packages/ansible/executor/task_executor.py", line 554, in _execute
result = self._handler.run(task_vars=variables)
File "/usr/lib/python2.7/site-packages/ansible/plugins/action/win_updates.py", line 189, in run
changed = result['changed']
KeyError: 'changed'

fatal: [server01]: FAILED! => {
"msg": "Unexpected failure during module execution.",
"stdout": ""
}

[jborean93]

@macampo this was an issue I unfortunately added with this change, the fix for that is here #38856.

@svpudik make sure you are on 2.5.1 or 2.5.2, this change was added in 2.5.1.

In the future, please raise a separate PR as we don't usually monitor closed issues and PRs