Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lambda policy arn #38863

Merged
merged 2 commits into from Apr 17, 2018
Merged

Lambda policy arn #38863

merged 2 commits into from Apr 17, 2018

Conversation

willthames
Copy link
Contributor

SUMMARY

Fix lambda_policy's handling of function_name parameters that are ARNs and add test case.

Modernize lambda_policy's test suite (full YAML syntax, use YAML anchors, use aws_caller_facts rather than CLI)

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lambda_policy

ANSIBLE VERSION
ansible 2.6.0 (lambda_policy_arn fda287e616) last updated 2018/04/17 15:26:07 (GMT +1000)
  config file = None
  configured module search path = [u'/home/will/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /home/will/src/ansible/lib/ansible
  executable location = /home/will/src/ansible/bin/ansible
  python version = 2.7.14 (default, Mar 14 2018, 13:36:31) [GCC 7.3.1 20180303 (Red Hat 7.3.1-5)]
ADDITIONAL INFORMATION

Supersedes #38533
Fixes #38769

Fix the function_name handling logic for lambda_policy
a1fd94c 
Switch the logic handling function_names that are ARNs
so that ARNs are correctly handled and detected
@ansibot
Copy link
Contributor

ansibot commented Apr 17, 2018

cc @mikedlr @pjodouin
click here for bot help

@ansibot ansibot added aws bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests. labels Apr 17, 2018
@ansibot
Copy link
Contributor

ansibot commented Apr 17, 2018

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

test/integration/targets/lambda_policy/tasks/main.yml:224:1: empty-lines too many blank lines (1 > 0)

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Apr 17, 2018
Add tests for lambda_policy function_arn
0cfed42 
Ensure that function_arn works.

Needs a reasonable ansible_lambda_role.
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Apr 17, 2018
@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Apr 17, 2018
@s-hertel s-hertel merged commit 0b4f92d into ansible:devel Apr 17, 2018
@ryansb ryansb mentioned this pull request May 3, 2018
Closed
ilicmilan pushed a commit to ilicmilan/ansible that referenced this pull request Nov 7, 2018
@willthames @ilicmilan
Lambda policy arn (ansible#38863)
94b4e51 
* Fix the function_name handling logic for lambda_policy

Switch the logic handling function_names that are ARNs
so that ARNs are correctly handled and detected

* Add tests for lambda_policy function_arn

Ensure that function_arn works.

Needs a reasonable ansible_lambda_role.
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryansb ryansb ryansb approved these changes

@s-hertel s-hertel s-hertel approved these changes

Assignees
No one assigned
Labels
aws bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lambda_policy is complaining about invalid characters that should be accepted.
4 participants
@willthames @ansibot @ryansb @s-hertel