Invert condition when validating function name

[martinwilkerson-scisys]

SUMMARY

In validate_params the .startswith('arn:') condition for function name validation was reversed, so if the string started arn: the check was for a standard function name i.e. does not contain ':'.

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

lambda_policy

ANSIBLE VERSION

ansible 2.5.0
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/home/vagrant/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python2.7/dist-packages/ansible
  executable location = /usr/bin/ansible
  python version = 2.7.12 (default, Dec  4 2017, 14:50:18) [GCC 5.4.0 20160609]

ADDITIONAL INFORMATION

When using the lambda_policy module it was not possible to use an arn for the function_name parameter as the validation checked that strings starting arn: do not contain :.

[ansibot]

cc @mikedlr @pjodouin @willthames
click here for bot help

[webknjaz]

!component lib/ansible/modules/cloud/amazon/lambda_policy.py

-label needs_triage

[dumblerod]

I ran into this as well and instead of doing the not, reversed the logic inside the if so the positive is first. Either way works, not sure what is preferable.

[willthames]

Yep, although this is the simplest diff, @JRODJ's solution is preferable as it's more readable.

I have a fix in for that and will update the tests to actually check that they work with a function_arn.

[ryansb]

This has been solved via #38863