postgresql_db dump does not fail on FATAL error when using compression

[d-fence]

ISSUE TYPE

• Bug Report

COMPONENT NAME

postgresql_db

ANSIBLE VERSION

ansible 2.5.1
  config file = /home/xxx/ansible/ansible.cfg
  configured module search path = [u'/home/xxx/ansible/library']
  ansible python module location = /home/xxx/.virtualenvs/ansiblexxx/local/lib/python2.7/site-packages/ansible
  executable location = /home/xxx/.virtualenvs/ansiblexxx/bin/ansible
  python version = 2.7.14 (default, Sep 23 2017, 22:06:14) [GCC 7.2.0]

CONFIGURATION

ANSIBLE_NOCOWS(/home/xxx/ansible/ansible.cfg) = True
ANSIBLE_PIPELINING(/home/xxx/ansible/ansible.cfg) = True
DEFAULT_FORKS(/home/xxx/ansible/ansible.cfg) = 50
DEFAULT_HOST_LIST(/home/xxx/ansible/ansible.cfg) = [u'/home/xxx/ansible/inventories']
DEFAULT_MODULE_PATH(/home/xxx/ansible/ansible.cfg) = [u'/home/xxx/ansible/library']
DEFAULT_MODULE_UTILS_PATH(/home/xxx/ansible/ansible.cfg) = [u'/home/xxx/ansible/module_utils']
DEFAULT_ROLES_PATH(/home/xxx/ansible/ansible.cfg) = [u'/home/xxx/ansible/roles']
INVENTORY_IGNORE_EXTS(/home/xxx/ansible/ansible.cfg) = ['~', '.orig', '.bak', '.ini', '.cfg', '.retry', '.pyc', '.pyo', '.cache']

OS / ENVIRONMENT

N/A
postgresql 9.5

SUMMARY

When using the dump state to dump a database, with compression like .gz, if an error occurs, it's not propagated to ansible. It seems that rc contains only the return code of the gzip program.

STEPS TO REPRODUCE

---
- name: Backup xxx DB
  hosts: xxx_hosts
  tasks:
  - name: Backup xxx database
    become: True
    become_user: postgres
    postgresql_db:
      name: non_existsing_db
      state: dump
      target: /tmp/db.sql.gz

EXPECTED RESULTS

The playbook should fail and stop right after the failed dump

ACTUAL RESULTS

changed: [xxx.yyy.com] => {"changed": true, "cmd": "/usr/bin/pg_dump non_existsing_db --port=5432 --username=postgres|/bin/gzip > /tmp/db.sql.gz", "msg": "", "rc": 0, "stderr": "pg_dump: [archiver (db)] connection to database \"non_existing_db\" failed: FATAL:  database \"non_existing_db\" does not exist\n", "stderr_lines": ["pg_dump: [archiver (db)] connection to database \"non_existing_db\" failed: FATAL:  database \"non_existing_db\" does not exist"]}

[ansibot]

Files identified in the description:

• lib/ansible/modules/database/postgresql/postgresql_db.py

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

[ansibot]

cc @matburt
click here for bot help

[Akasurde]

Closing this issue as PR #39483 is merged. If issue persists, please feel free to re-open.