ec2_ami is not deleting snapshots

[alan113696]

ISSUE TYPE

• Bug Report

COMPONENT NAME

ec2_ami

ANSIBLE VERSION

ansible 2.5.2
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/home/centos/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python2.7/site-packages/ansible
  executable location = /usr/bin/ansible
  python version = 2.7.5 (default, Aug  4 2017, 00:39:18) [GCC 4.8.5 20150623 (Red Hat 4.8.5-16)]

CONFIGURATION

OS / ENVIRONMENT

CentOS Linux release 7.4.1708 (Core)

SUMMARY

ec2_ami module does not appear to be deleting snapshots when using the "delete_snapshot=yes" parameter.

STEPS TO REPRODUCE

ansible -m ec2_ami -a "delete_snapshot=yes state=absent wait=yes image_id=ami-0ee6716f" localhost

EXPECTED RESULTS

Expected a response with non-empty "snapshots_deleted" list.

ACTUAL RESULTS

localhost | SUCCESS => {
    "changed": true, 
    "invocation": {
        "module_args": {
            "architecture": "x86_64", 
            "aws_access_key": null, 
            "aws_secret_key": null, 
            "billing_products": null, 
            "delete_snapshot": true, 
            "description": "", 
            "device_mapping": null, 
            "ec2_url": null, 
            "enhanced_networking": null, 
            "image_id": "ami-0ee6716f", 
            "image_location": null, 
            "instance_id": null, 
            "kernel_id": null, 
            "launch_permissions": null, 
            "name": null, 
            "no_reboot": false, 
            "profile": null, 
            "purge_tags": false, 
            "ramdisk_id": null, 
            "region": null, 
            "root_device_name": null, 
            "security_token": null, 
            "sriov_net_support": null, 
            "state": "absent", 
            "tags": null, 
            "validate_certs": true, 
            "virtualization_type": "hvm", 
            "wait": true, 
            "wait_timeout": 900
        }
    }, 
    "msg": "AMI deregister operation complete.", 
    "snapshots_deleted": []
}

[ansibot]

Files identified in the description:

• lib/ansible/modules/cloud/amazon/ec2_ami.py

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

[ansibot]

cc @Constantin007 @Constantin07 @gunzy83 @scicoin-project @willthames @wilvk
click here for bot help

[alan113696]

The following code might need to be revised:

ansible/lib/ansible/modules/cloud/amazon/ec2_ami.py

Lines 496 to 501 in e9270fb

	snapshots = []
	if 'BlockDeviceMappings' in image:
	for mapping in image.get('BlockDeviceMappings'):
	snapshot_id = mapping.get('SnapshotId')
	if snapshot_id is not None:
	snapshots.append(snapshot_id)

BlockDeviceMappings data structure looks like:

"BlockDeviceMappings": [
    {
           "DeviceName": "/dev/sda1", 
           "Ebs": {
               "Encrypted": false, 
               "DeleteOnTermination": true, 
               "VolumeType": "gp2", 
               "VolumeSize": 8, 
               "SnapshotId": "snap-03d5c521dd94a89bb"
           }
   }
],

Note that SnapshotId is nested within Ebs.