Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ec2_ami: fix deleting snapshots - fixes #39541 #39606

Merged
merged 1 commit into from
May 3, 2018
Merged

ec2_ami: fix deleting snapshots - fixes #39541 #39606

merged 1 commit into from
May 3, 2018

Conversation

s-hertel
Copy link
Contributor

@s-hertel s-hertel commented May 2, 2018

SUMMARY

Fixes #39541 and adds an assertion to a test that would have caught this bug.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/modules/cloud/amazon/ec2_ami.py

ANSIBLE VERSION
2.6.0

@ansibot
Copy link
Contributor

ansibot commented May 2, 2018

cc @Constantin007 @Constantin07 @gunzy83 @scicoin-project @willthames @wilvk
click here for bot help

@ansibot ansibot added aws bug This issue/PR relates to a bug. cloud committer_review In order to be merged, this PR must follow the certified review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:certified This issue/PR relates to certified code. test This PR relates to tests. labels May 2, 2018
@gundalow gundalow removed the needs_triage Needs a first human triage before being processed. label May 2, 2018
@ryansb ryansb self-requested a review May 3, 2018 11:47
@ryansb ryansb merged commit 910bc89 into ansible:devel May 3, 2018
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 12, 2018
@s-hertel
ec2_ami: Properly delete snapshots (ansible#39606)
8f44c78
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 14, 2018
@s-hertel
ec2_ami: Properly delete snapshots (ansible#39606)
089486d
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 14, 2018
@s-hertel
ec2_ami: Properly delete snapshots (ansible#39606)
585a406
tonal pushed a commit to tonal/ansible that referenced this pull request May 15, 2018
@s-hertel
ec2_ami: Properly delete snapshots (ansible#39606)
9db1852
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 15, 2018
@s-hertel
ec2_ami: Properly delete snapshots (ansible#39606)
14c8f70
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 15, 2018
@s-hertel
ec2_ami: Properly delete snapshots (ansible#39606)
1d9aa05
@alexntt alexntt mentioned this pull request Jun 22, 2018
Closed
ilicmilan pushed a commit to ilicmilan/ansible that referenced this pull request Nov 7, 2018
@s-hertel @ilicmilan
ec2_ami: Properly delete snapshots (ansible#39606)
4833620
@ansible ansible locked and limited conversation to collaborators May 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryansb ryansb ryansb approved these changes

Assignees
No one assigned
Labels
aws bug This issue/PR relates to a bug. cloud committer_review In order to be merged, this PR must follow the certified review workflow. module This issue/PR relates to a module. support:certified This issue/PR relates to certified code. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ec2_ami is not deleting snapshots
4 participants
@s-hertel @ansibot @ryansb @gundalow