Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renaming letsencrypt -> acme_certificate. #39816

Merged
merged 2 commits into from May 8, 2018
Merged

Renaming letsencrypt -> acme_certificate. #39816

merged 2 commits into from May 8, 2018

Conversation

felixfontein
Copy link
Contributor

SUMMARY

Fixes #39737: renames the letsencrypt module to acme_certificate to avoid trademark conflict with Let's Encrypt.

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

letsencrypt

ANSIBLE VERSION

2.6.0

@ansibot
Copy link
Contributor

ansibot commented May 7, 2018

@AlanCoding @Slezhuk @agmezr @berendt @ghjm @hogarthj @inetfuture @jhoekx @jlaska @jtyr @lekum @matburt @mattupstate @mgruener @n0trax @nerzhul @oboukili @ramondelafuente @robinro @rooftopcellist @ryanpetrello @scottanderson42 @sermilrod @simfarm @stpierre @tarka @tastychutney @wwitzel3

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@ansibot ansibot added bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_module This PR includes a new module. support:community This issue/PR relates to code supported by the Ansible community. labels May 7, 2018
@felixfontein
Copy link
Contributor Author

CC @resmo, @bcoca

@felixfontein felixfontein mentioned this pull request May 7, 2018
Closed
@resmo
Copy link
Contributor

resmo commented May 7, 2018

@felixfontein please rename https://github.com/ansible/ansible/blob/devel/.github/BOTMETA.yml#L696 as well

@felixfontein
Copy link
Contributor Author

@resmo should I rename it, or duplicate the line for both names? (And if both: letsencrypt or _letsencrypt?) I.e. if I rename it, what happens if someone files a bug against the letsencrypt module? Will we be informed or not if there's no line for it?

@felixfontein
Copy link
Contributor Author

I added a simple rename for now.

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. support:core This issue/PR relates to code supported by the Ansible Engineering Team. and removed community_review In order to be merged, this PR must follow the community review workflow. labels May 8, 2018
@resmo
Copy link
Contributor

resmo commented May 8, 2018

@felixfontein not sure how the bot handles module aliases but we'll find out.

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed core_review In order to be merged, this PR must follow the core review workflow. labels May 8, 2018
@resmo resmo merged commit 83df724 into ansible:devel May 8, 2018
@felixfontein felixfontein deleted the rename-letsencrypt branch May 8, 2018 11:54
@felixfontein felixfontein mentioned this pull request May 10, 2018
Merged
@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label May 11, 2018
@felixfontein felixfontein mentioned this pull request May 11, 2018
Closed
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 12, 2018
@felixfontein
Renaming letsencrypt -> acme_certificate (ansible#39816)
fb2fd8a 
* Renaming letsencrypt -> acme_certificate.

* Also renaming in BOTMETA.yml.
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 14, 2018
@felixfontein
Renaming letsencrypt -> acme_certificate (ansible#39816)
a3e8299 
* Renaming letsencrypt -> acme_certificate.

* Also renaming in BOTMETA.yml.
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 14, 2018
@felixfontein
Renaming letsencrypt -> acme_certificate (ansible#39816)
7879c53 
* Renaming letsencrypt -> acme_certificate.

* Also renaming in BOTMETA.yml.
tonal pushed a commit to tonal/ansible that referenced this pull request May 15, 2018
@felixfontein
Renaming letsencrypt -> acme_certificate (ansible#39816)
d4aee72 
* Renaming letsencrypt -> acme_certificate.

* Also renaming in BOTMETA.yml.
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 15, 2018
@felixfontein
Renaming letsencrypt -> acme_certificate (ansible#39816)
46743d9 
* Renaming letsencrypt -> acme_certificate.

* Also renaming in BOTMETA.yml.
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 15, 2018
@felixfontein
Renaming letsencrypt -> acme_certificate (ansible#39816)
27ef3ae 
* Renaming letsencrypt -> acme_certificate.

* Also renaming in BOTMETA.yml.
ilicmilan pushed a commit to ilicmilan/ansible that referenced this pull request Nov 7, 2018
@felixfontein @ilicmilan
Renaming letsencrypt -> acme_certificate (ansible#39816)
c72b063 
* Renaming letsencrypt -> acme_certificate.

* Also renaming in BOTMETA.yml.
@felixfontein felixfontein mentioned this pull request Nov 24, 2018
Closed
@dagwieers dagwieers added the crypto Crypto community (ACME, openssl, letsencrypt) label Feb 7, 2019
@ansible ansible locked and limited conversation to collaborators May 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
bug This issue/PR relates to a bug. crypto Crypto community (ACME, openssl, letsencrypt) module This issue/PR relates to a module. new_module This PR includes a new module. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

letsencrypt module should be renamed (to avoid violating Let's Encrypt's trademark policy)
5 participants
@felixfontein @ansibot @resmo @dagwieers @mkrizek