Use _remote_is_local=True for local connection in synchronize #40833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.7
|
Due to the Effectively, we only need to bypass using |
bcoca
removed
the
needs_triage
|
Example of failures: https://app.shippable.com/github/ansible/ansible/runs/67719/34/tests |
sivel
changed the title
bcoca
approved these changes
May 30, 2018
nitzmahone
reviewed
May 30, 2018
| @@ -246,3 +250,15 @@ def test_delegate_remote_su(self): | |||
| # delegate to other remote host with su enabled | |||
| x = SynchronizeTester() | |||
| x.runtest(fixturepath=os.path.join(self.fixturedir, 'delegate_remote_su')) | |||
|
|
|||
| @patch.object(ActionModule, '_low_level_execute_command', side_effect=BreakPoint) | |||
There was a problem hiding this comment.
Looks like it works fine, but the side_effect=BreakPoint here seems superfluous. Am I missing something?
There was a problem hiding this comment.
... or is that just to get it to bail out on that call?
There was a problem hiding this comment.
I'm short circuiting the execution of run by setting a side_effect on a function call that will actually connect to the server to expand the path. Otherwise it will try and go further, actually executing the module.
This allows me to kill execution immediately after what we are wanting to inspect.
There was a problem hiding this comment.
... or is that just to get it to bail out on that call?
Exactly that.
nitzmahone
approved these changes
May 30, 2018
|
rebuild_merge |
|
unrelated transient CI failure - merging |
sivel
added a commit
to sivel/ansible
that referenced
this pull request
May 30, 2018
…e#40833) * All instances of local connection should use _remote_is_local=True. Fixes ansible#40551 * Switch to instance attribute for synchronize * Add test that shows that synchronize _remote_is_local addresses tmpdir building (cherry picked from commit ad7ba91)
sivel
added a commit
to sivel/ansible
that referenced
this pull request
May 30, 2018
sivel
added a commit
to sivel/ansible
that referenced
this pull request
May 30, 2018
…e#40833) * All instances of local connection should use _remote_is_local=True. Fixes ansible#40551 * Switch to instance attribute for synchronize * Add test that shows that synchronize _remote_is_local addresses tmpdir building (cherry picked from commit ad7ba91)
sivel
added a commit
to sivel/ansible
that referenced
this pull request
May 30, 2018
This was referenced May 30, 2018
ansibot
pushed a commit
that referenced
this pull request
May 30, 2018
* Use _remote_is_local=True for local connection in synchronize (#40833) * All instances of local connection should use _remote_is_local=True. Fixes #40551 * Switch to instance attribute for synchronize * Add test that shows that synchronize _remote_is_local addresses tmpdir building (cherry picked from commit ad7ba91) * Add changelog entry for #40833
sivel
added a commit
that referenced
this pull request
May 30, 2018
* Use _remote_is_local=True for local connection in synchronize (#40833) * All instances of local connection should use _remote_is_local=True. Fixes #40551 * Switch to instance attribute for synchronize * Add test that shows that synchronize _remote_is_local addresses tmpdir building (cherry picked from commit ad7ba91) * Add changelog entry for #40833
jacum
pushed a commit
to jacum/ansible
that referenced
this pull request
Jun 26, 2018
…e#40833) * All instances of local connection should use _remote_is_local=True. Fixes ansible#40551 * Switch to instance attribute for synchronize * Add test that shows that synchronize _remote_is_local addresses tmpdir building
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
All instances of local connection should use _remote_is_local=True. Fixes #40551
ISSUE TYPE
COMPONENT NAME
lib/ansible/plugins/connection/local.py
ANSIBLE VERSION
ADDITIONAL INFORMATION