Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport #40833 for 2.6 - synchronize _remote_is_local #40918

Merged
merged 2 commits into from
May 30, 2018
Merged

Backport #40833 for 2.6 - synchronize _remote_is_local #40918

merged 2 commits into from
May 30, 2018

Conversation

sivel
Copy link
Member

@sivel sivel commented May 30, 2018

SUMMARY

Backport #40833 for 2.6 - synchronize _remote_is_local

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/plugins/action/synchronize.py

ANSIBLE VERSION
2.6
ADDITIONAL INFORMATION

sivel added 2 commits May 30, 2018 15:34
@sivel
Use _remote_is_local=True for local connection in synchronize (ansibl…
8882893 
…e#40833)

* All instances of local connection should use _remote_is_local=True. Fixes ansible#40551

* Switch to instance attribute for synchronize

* Add test that shows that synchronize _remote_is_local addresses tmpdir building

(cherry picked from commit ad7ba91)
@sivel
Add changelog entry for ansible#40833
2620a82
@sivel sivel requested a review from mattclay May 30, 2018 20:37
@ansibot ansibot added affects_2.6 This issue/PR affects Ansible v2.6 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels May 30, 2018
@ansibot ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label May 30, 2018
@sivel
Copy link
Member Author

sivel commented May 30, 2018

Unrelated transient failures caused the unstable state. Proceeding with merging.

@sivel sivel merged commit 87a1630 into ansible:stable-2.6 May 30, 2018
@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label May 31, 2018
@ansible ansible locked and limited conversation to collaborators May 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattclay mattclay mattclay approved these changes

Assignees
No one assigned
Labels
affects_2.6 This issue/PR affects Ansible v2.6 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sivel @mattclay @mkrizek @ansibot