Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Digital Ocean Block Storage Bug #41431

Merged
merged 1 commit into from
Jun 12, 2018
Merged

Digital Ocean Block Storage Bug #41431

merged 1 commit into from
Jun 12, 2018

Conversation

BondAnthony
Copy link
Contributor

SUMMARY

Digital Ocean Volumes API changed causing Ansible to recieve an unexpected value in the response. This resulted in Ansible not being able to validate the state of existing volumes.

This resolves #39655 by changing the ID to conflict.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/modules/cloud/digital_ocean/digital_ocean_block_storage.py

ANSIBLE VERSION
ansible 2.7.0.dev0 (bugfix/issue-39655 57f681c926) last updated 2018/06/10 19:45:01 (GMT -400)
  config file = /Users/abond/ansible/ansible.cfg
  configured module search path = ['/Users/abond/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /Users/abond/Development/github/ansible/lib/ansible
  executable location = /Users/abond/Development/github/ansible/bin/ansible
  python version = 3.6.5 (default, Mar 30 2018, 06:41:49) [GCC 4.2.1 Compatible Apple LLVM 8.0.0 (clang-800.0.42.1)]

@BondAnthony BondAnthony mentioned this pull request Jun 12, 2018
Closed
@ansibot
Copy link
Contributor

ansibot commented Jun 12, 2018

cc @harneksidhu
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. digital_ocean module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community. labels Jun 12, 2018
@BondAnthony
Copy link
Contributor Author

cc @Akasurde and @pmarques for a friendly review, please.

@Akasurde Akasurde removed the needs_triage Needs a first human triage before being processed. label Jun 12, 2018
@pmarques
Copy link
Contributor

following #39655 LGTM

@pmarques
Copy link
Contributor

shipit

@ansibot ansibot added automerge This PR was automatically merged by ansibot. shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. labels Jun 12, 2018
@ansibot ansibot merged commit 4efe53e into ansible:devel Jun 12, 2018
@Akasurde
Copy link
Member

@BondAnthony Thanks for the PR. @pmarques Thanks for the review.

@BondAnthony
Copy link
Contributor Author

@Akasurde could you back port this change?

@BondAnthony BondAnthony deleted the bugfix/issue-39655 branch June 12, 2018 10:08
Akasurde pushed a commit to Akasurde/ansible that referenced this pull request Jun 12, 2018
@BondAnthony @Akasurde
Digital Ocean Block Storage Bug (ansible#41431)
e134365 
Fix added for Digital Ocean Volumes API change causing Ansible to recieve an unexpected value in the response.

Signed-off-by: ABond <ajbond2005@gmail.com>
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>

(cherry picked from commit 4efe53e)
@Akasurde
Copy link
Member

Akasurde commented Jun 12, 2018 •
edited

@BondAnthony Backport for Stable-2.6 #41440

mattclay pushed a commit that referenced this pull request Jun 12, 2018
@BondAnthony @mattclay
Digital Ocean Block Storage Bug (#41431)
cda4b6d 
Fix added for Digital Ocean Volumes API change causing Ansible to recieve an unexpected value in the response.

Signed-off-by: ABond <ajbond2005@gmail.com>
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>

(cherry picked from commit 4efe53e)
jacum pushed a commit to jacum/ansible that referenced this pull request Jun 26, 2018
@BondAnthony
Digital Ocean Block Storage Bug (ansible#41431)
414fb15
@ansible ansible locked and limited conversation to collaborators Jun 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pmarques pmarques pmarques approved these changes

Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 automerge This PR was automatically merged by ansibot. bug This issue/PR relates to a bug. cloud digital_ocean module This issue/PR relates to a module. owner_pr This PR is made by the module's maintainer. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

digital_ocean_block_storage stopped working
4 participants
@BondAnthony @ansibot @pmarques @Akasurde